All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jan Engelhardt <jengelh@inai.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] http-backend: give a hint that web browser access is not supported
Date: Wed, 01 Dec 2021 23:38:24 -0800	[thread overview]
Message-ID: <xmqqee6vwj67.fsf@gitster.g> (raw)
In-Reply-To: <20211202003900.26124-1-jengelh@inai.de> (Jan Engelhardt's message of "Thu, 2 Dec 2021 01:39:00 +0100")

Jan Engelhardt <jengelh@inai.de> writes:

>  http-backend.c          | 36 +++++++++++++++++++++++++++-----
>  t/t5561-http-backend.sh | 46 ++++++++++++++++++++---------------------
>  2 files changed, 54 insertions(+), 28 deletions(-)
>
> diff --git http-backend.c http-backend.c
> index 3d6e2ff17f..f7858e9c49 100644
> --- http-backend.c
> +++ http-backend.c

Please fix your format-patch settings.  The comparisons should be
between a/http-backend.c and b/http-backend.c and not between the
same path at the top-level.

Everybody uses -p1 patches around here and their tools are set-up to
handle -p1 patches.

Thanks.

  reply	other threads:[~2021-12-02  7:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  0:39 [PATCH] http-backend: give a hint that web browser access is not supported Jan Engelhardt
2021-12-02  7:38 ` Junio C Hamano [this message]
2021-12-02 10:27   ` RFE: Split diff.noprefix for git-diff and git-format-patch (was: http-backend: give a hint that web browser access is not supported) Jan Engelhardt
2021-12-02 17:20     ` RFE: Split diff.noprefix for git-diff and git-format-patch Junio C Hamano
2021-12-02 10:28   ` [PATCH] http-backend: give a hint that web browser access is not supported Jan Engelhardt
2021-12-04  8:09     ` Junio C Hamano
2021-12-04 11:09       ` Jan Engelhardt
2021-12-05  1:17         ` Junio C Hamano
2021-12-05 10:13           ` Jan Engelhardt
2021-12-05 20:13             ` Junio C Hamano
2021-12-05 23:07               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqee6vwj67.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jengelh@inai.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.