From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>,
liu.denton@gmail.com
Subject: Re: [PATCH] ls-files: use imperative mood for -X and -z option description
Date: Mon, 20 Sep 2021 12:30:54 -0700 [thread overview]
Message-ID: <xmqqee9javtd.fsf@gitster.g> (raw)
In-Reply-To: <YUij2Aj04B1Q1tRV@nand.local> (Taylor Blau's message of "Mon, 20 Sep 2021 11:08:08 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> Your patch looks fine to me. I don't think it's urgent to change, but it
> looks correct nonetheless.
>
>> Cc: Jeff King <peff@peff.net>
>> Cc: <liu.denton@gmail.com>
>
> These Cc trailers can be removed. (They're not entirely unprecedented,
> but I can only find ~200 examples in git.git's history).
Yup, "can" and probably "should". It is meant for consumption by
your e-mail software.
>> OPT_SET_INT('z', NULL, &line_terminator,
>> - N_("paths are separated with NUL character"), '\0'),
>> + N_("separate paths with NUL character"), '\0'),
>
> The text before your patch should include an article so it reads "with
> [the] NUL character" instead of "with NUL character".
>
> So I think the right post-image would be: "separate paths with the NUL
> character".
Correct. Grammar fixes are very much appreciated, especially in an
international project like this one.
Thanks.
prev parent reply other threads:[~2021-09-20 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:19 [PATCH] ls-files: use imperative mood for -X and -z option description Bagas Sanjaya
2021-09-20 15:08 ` Taylor Blau
2021-09-20 19:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqee9javtd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.