From: Junio C Hamano <gitster@pobox.com>
To: Chris Torek <chris.torek@gmail.com>
Cc: Neeraj Singh <nksingh85@gmail.com>,
Jeff Hostetler <git@jeffhostetler.com>,
Git List <git@vger.kernel.org>,
"Neeraj K. Singh" <neerajsi@microsoft.com>
Subject: Re: [PATCH] read-cache: make the index write buffer size 128K
Date: Wed, 24 Feb 2021 23:16:42 -0800 [thread overview]
Message-ID: <xmqqeeh4wrad.fsf@gitster.g> (raw)
In-Reply-To: <CAPx1GvdA1prtO+y-bJ7yu8oZP6Lp9mHQ5gv-fXvS193NFospkA@mail.gmail.com> (Chris Torek's message of "Wed, 24 Feb 2021 22:58:36 -0800")
Chris Torek <chris.torek@gmail.com> writes:
> Linux/BSD/etc `stat` system calls report st_blksize values to tell
> user code the optimal size for read and write calls. Does Windows
> have one? (It's not POSIX but is XSI.)
>
> (How *well* the OS reports `st_blksize` is another question
> entirely, but at least if the report says, say, 128k, and that's
> wrong, that's no longer Git's fault. :-) )
> ...
> 128K is correct for ZFS; 64K is typically correct for UFS2; 8K is
> the old UFS1 size. Anything under that has been too small for
> a long time. :-)
That's rather tempting. After opening a locked index to write
things out, the value is a single fstat() away...
next prev parent reply other threads:[~2021-02-25 7:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 2:48 [PATCH] read-cache: make the index write buffer size 128K Neeraj K. Singh via GitGitGadget
2021-02-19 19:12 ` Jeff Hostetler
2021-02-20 3:28 ` Junio C Hamano
2021-02-20 7:56 ` Neeraj Singh
2021-02-21 12:51 ` Junio C Hamano
2021-02-24 20:56 ` Neeraj Singh
2021-02-25 5:41 ` Junio C Hamano
2021-02-25 6:58 ` Chris Torek
2021-02-25 7:16 ` Junio C Hamano [this message]
2021-02-25 7:36 ` Neeraj Singh
2021-02-25 7:57 ` Chris Torek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeeh4wrad.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chris.torek@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=neerajsi@microsoft.com \
--cc=nksingh85@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.