All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Beat Bolli <dev+git@drbeat.li>, git@vger.kernel.org
Subject: Re: [PATCH] pretty: allow to override the built-in formats
Date: Sun, 06 Sep 2020 14:59:32 -0700	[thread overview]
Message-ID: <xmqqeene36t7.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: 20200905195218.GA892287@generichostname

Denton Liu <liu.denton@gmail.com> writes:

> Hmm, I'm not sure how I feel about being able to override formats other
> than "reference".

Is the idea to introduce a parallel namespace to pretty.<name>?  I
am not sure why that is a good idea than, say a single variable that
says "to me, pretty.<name> would override even the built-in names".

I am not sure how I feel about being able to override built-in
formats in the first place, though.

After all, pretty.<name> were introduced so that user-defined ones
can be invoked with an equal ease as the built-in ones, but
overriding common understanding among the users of the tool is a
different story.

  reply	other threads:[~2020-09-06 21:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05 19:24 [PATCH] pretty: allow to override the built-in formats Beat Bolli
2020-09-05 19:52 ` Denton Liu
2020-09-06 21:59   ` Junio C Hamano [this message]
2020-09-07  5:36     ` Beat Bolli
2020-09-07  6:54       ` Junio C Hamano
2020-09-07  7:06         ` Beat Bolli
2020-09-08 13:53         ` Jeff King
2020-09-08 18:12           ` Junio C Hamano
2020-09-09  9:08             ` Jeff King
2020-09-09 18:27               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeene36t7.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    --cc=liu.denton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.