From: Junio C Hamano <gitster@pobox.com>
To: Masaya Suzuki <masayasuzuki@google.com>
Cc: git@vger.kernel.org, peff@peff.net, steadmon@google.com
Subject: Re: [PATCH v2 0/2] Accept error packets in any context
Date: Thu, 03 Jan 2019 15:05:35 -0800 [thread overview]
Message-ID: <xmqqef9tfikg.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181229211915.161686-1-masayasuzuki@google.com> (Masaya Suzuki's message of "Sat, 29 Dec 2018 13:19:13 -0800")
Masaya Suzuki <masayasuzuki@google.com> writes:
> This makes it possible for servers to send an error message back to clients in
> an arbitrary situation.
>
> The first patch was originally sent in [1]. This version includes some fix.
>
> The second patch was originally sent in [2]. Later, this was cherry-picked in
> [3]. In the discussion in [3], we agreed that this error packet handling should
> be done only against the Git pack protocol handling code. With this agreement,
> the patch series sent in [3] is abandoned (according to [4]). This is a patch
> series based on that agreement on limiting the error packet handling.
In short, are you shooting js/smart-http-detect-remote-error topic
down and replacing it with this one?
As that topic is not yet in 'next', I am perfectly fine doing that.
I just want to make sure that is what you meant, as my reading of
[4] was a bit fuzzy.
Thanks.
>
> [1]: https://public-inbox.org/git/20181227065210.60817-1-masayasuzuki@google.com/
> [2]: https://public-inbox.org/git/20181127045301.103807-1-masayasuzuki@google.com/
> [3]: https://public-inbox.org/git/df7d3659ae5f11d163f1e992f3b9403be709ddb7.1544572142.git.steadmon@google.com/
> [4]: https://public-inbox.org/git/20181213221826.GE37614@google.com/
>
> Masaya Suzuki (2):
> Use packet_reader instead of packet_read_line
> pack-protocol.txt: accept error packets in any context
next prev parent reply other threads:[~2019-01-03 23:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <reply-to=20181127045301.103807-1-masayasuzuki@google.com>
2018-12-29 21:19 ` [PATCH v2 0/2] Accept error packets in any context Masaya Suzuki
2018-12-29 21:19 ` [PATCH v2 1/2] Use packet_reader instead of packet_read_line Masaya Suzuki
2019-01-07 19:01 ` Jonathan Tan
2019-01-07 22:33 ` Josh Steadmon
2019-01-08 23:27 ` Masaya Suzuki
2018-12-29 21:19 ` [PATCH v2 2/2] pack-protocol.txt: accept error packets in any context Masaya Suzuki
2019-01-07 19:41 ` Jonathan Tan
2019-01-07 22:53 ` Josh Steadmon
2019-01-03 23:05 ` Junio C Hamano [this message]
2019-01-04 0:20 ` [PATCH v2 0/2] Accept " Masaya Suzuki
2019-01-15 1:43 ` Jonathan Nieder
2019-01-15 1:49 ` Jonathan Nieder
2019-01-15 18:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqef9tfikg.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=masayasuzuki@google.com \
--cc=peff@peff.net \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.