All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Stefan Beller <sbeller@google.com>,
	Git Mailing List <git@vger.kernel.org>,
	Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path
Date: Fri, 22 Jul 2016 12:39:45 -0700	[thread overview]
Message-ID: <xmqqeg6la2da.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <4d40da99-2f66-a380-840f-1828dc5b9324@kdbg.org> (Johannes Sixt's message of "Fri, 22 Jul 2016 21:15:39 +0200")

Johannes Sixt <j6t@kdbg.org> writes:

> 'git submodule--helper update-clone' has logic to retry failed clones
> a second time. For this purpose, there is a list of submodules to clone,
> and a second list that is filled with the submodules to retry. Within
> these lists, the submodules are identified by an index as if both lists
> were just appended.
>
> This works nicely except when the second clone attempt fails as well. To
> report an error, the identifying index must be adjusted by an offset so
> that it can be used as an index into the second list. However, the
> calculation uses the logical total length of the lists so that the result
> always points one past the end of the second list.
>
> Pick the correct index.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---

Looks very similar to

  http://public-inbox.org/git/20160721013923.17435-1-sbeller%40google.com/

but these two patch series looks more thorough.

I expect I'd queue these two instead, after seeing Acks from Stefan.

Thanks.

  parent reply	other threads:[~2016-07-22 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22 19:14 [PATCH 1/2] git-submodule: forward exit code of git-submodule--helper more faithfully Johannes Sixt
2016-07-22 19:15 ` [PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path Johannes Sixt
2016-07-22 19:30   ` Stefan Beller
2016-07-22 19:52     ` Junio C Hamano
2016-07-22 20:00       ` Stefan Beller
2016-07-22 19:39   ` Junio C Hamano [this message]
2016-07-22 19:50     ` Stefan Beller
2016-07-22 20:00       ` Junio C Hamano
2016-07-22 19:27 ` [PATCH 1/2] git-submodule: forward exit code of git-submodule--helper more faithfully Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeg6la2da.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.