All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
	"Michael Rappazzo" <rappazzo@gmail.com>,
	"Duy Nguyen" <pclouds@gmail.com>,
	"SZEDER Gábor" <szeder@ira.uka.de>,
	"Johannes Sixt" <j.sixt@viscovery.net>
Subject: Re: [PATCH v2 3/5] t1500: avoid changing working directory outside of tests
Date: Tue, 17 May 2016 13:37:39 -0700	[thread overview]
Message-ID: <xmqqeg90v2ss.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160517193630.10379-4-sunshine@sunshineco.com> (Eric Sunshine's message of "Tue, 17 May 2016 15:36:28 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> +			git ${dir:+-C "$dir"} rev-parse --$o >actual &&

This is kosher POSIX, but I vaguely recall some shells had trouble
with the SP between -C and "$dir" in the past.  Let's see if anybody
screams; hopefully I am misremembering or buggy shells died out.

Other than that, the entire series makes the script easier to grok.
Thanks.

  reply	other threads:[~2016-05-17 20:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 19:36 [PATCH v2 0/5] modernize t1500 Eric Sunshine
2016-05-17 19:36 ` [PATCH v2 1/5] t1500: be considerate to future potential tests Eric Sunshine
2016-05-17 19:36 ` [PATCH v2 2/5] t1500: test_rev_parse: facilitate future test enhancements Eric Sunshine
2016-05-18 16:38   ` SZEDER Gábor
2016-05-18 17:32     ` Eric Sunshine
2016-05-18 17:43       ` Eric Sunshine
2016-05-17 19:36 ` [PATCH v2 3/5] t1500: avoid changing working directory outside of tests Eric Sunshine
2016-05-17 20:37   ` Junio C Hamano [this message]
2016-05-17 20:48     ` Eric Sunshine
2016-05-17 21:52       ` Jeff King
2016-05-17 22:48         ` Eric Sunshine
2016-05-17 22:48         ` Junio C Hamano
2016-05-17 23:06           ` SZEDER Gábor
2016-05-18  3:33             ` Eric Sunshine
2016-05-17 19:36 ` [PATCH v2 4/5] t1500: avoid setting configuration options " Eric Sunshine
2016-05-17 19:36 ` [PATCH v2 5/5] t1500: avoid setting environment variables " Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeg90v2ss.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=rappazzo@gmail.com \
    --cc=sunshine@sunshineco.com \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.