All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Johannes Schindelin" <johannes.schindelin@gmx.de>,
	git@vger.kernel.org,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Andreas Schwab" <schwab@linux-m68k.org>,
	"Olaf Hering" <olaf@aepfle.de>,
	"Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
Subject: Re: [PATCH] name-rev: include taggerdate in considering the best name
Date: Fri, 22 Apr 2016 11:27:28 -0700	[thread overview]
Message-ID: <xmqqeg9xpkhb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160422181103.GA5920@sigill.intra.peff.net> (Jeff King's message of "Fri, 22 Apr 2016 14:11:04 -0400")

Jeff King <peff@peff.net> writes:

> That turned out to be quite simple (I wasn't sure originally if we'd
> actually visit all of the tags, which is why I had conceived of this as
> an initial pass; but of course it makes sense that we'd have to see all
> of the tags in the existing code).
> ...
> We could _also_ tweak the merge-weight as Linus's patch did, just
> because 10000 has more basis than 65535. But I think it really matters a
> lot less at this point.

I agree, but if we were to go this route of keeping track of "some"
attribute of the tip the traversal started from, I wonder if it is
better to keep the actual tag object, not just its tagger date as an
unsigned long, in the new field.

That way, a tweak may be able to even use the v:refname comparison
if we wanted to do so in the future.  It is easy to go from a tag
object to its tagger date, but it is impossible to go in the other
direction, i.e. given a tagger date to go back to the tag.

  reply	other threads:[~2016-04-22 18:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 13:39 [PATCH] name-rev: include taggerdate in considering the best name Johannes Schindelin
2016-04-22 18:11 ` Jeff King
2016-04-22 18:27   ` Junio C Hamano [this message]
2016-04-22 18:40     ` Junio C Hamano
2016-04-22 18:45   ` Linus Torvalds
2016-04-22 20:50     ` Junio C Hamano
2016-04-24  6:35       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeg9xpkhb.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=olaf@aepfle.de \
    --cc=peff@peff.net \
    --cc=schwab@linux-m68k.org \
    --cc=torvalds@linux-foundation.org \
    --cc=ukleinek@informatik.uni-freiburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.