All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Eric Sunshine <sunshine@sunshineco.com>, git@vger.kernel.org
Subject: Re: [PATCH] utf8: NO_ICONV: silence uninitialized variable warning
Date: Fri, 05 Jun 2015 15:19:04 -0700	[thread overview]
Message-ID: <xmqqeglpre7b.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150605092309.GA11855@peff.net> (Jeff King's message of "Fri, 5 Jun 2015 05:23:09 -0400")

Jeff King <peff@peff.net> writes:

> So I think your patch is the best option, but it might be good to give
> one more look at the callers to be sure we are not missing something.

The two callers both leave the outsz uninitialized and to a human it
is obvious that uninitialized outsz is never used when the function
or macro returns NULL.  It is somewhat sad that we need a useless
assignment to *e to help less than intelligent compilers, but it is
possible that a clever compiler may be able to optimize the useless
assignment away so it might even out in the end ;-)

Will queue.

Thanks.

      reply	other threads:[~2015-06-05 22:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  6:42 [PATCH] utf8: NO_ICONV: silence uninitialized variable warning Eric Sunshine
2015-06-05  9:23 ` Jeff King
2015-06-05 22:19   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeglpre7b.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.