From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org, Johan Herland <johan@herland.net>,
Josh Triplett <josh@joshtriplett.org>,
Thomas Rast <tr@thomasrast.ch>,
Michael Haggerty <mhagger@alum.mit.edu>,
Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <greg@kroah.com>, Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v12 11/11] Documentation: add documentation for 'git interpret-trailers'
Date: Wed, 28 May 2014 12:35:37 -0700 [thread overview]
Message-ID: <xmqqegzdd7cm.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140525053223.5329.28002.chriscool@tuxfamily.org> (Christian Couder's message of "Sun, 25 May 2014 07:32:22 +0200")
Christian Couder <chriscool@tuxfamily.org> writes:
> +The trailers are recognized in the input message using the following
> +rules:
> +
> +* only lines that contains a ':' (colon) are considered trailers,
> +
> +* the trailer lines must all be next to each other,
> +
> +* after them it's only possible to have some lines that contain only
> + spaces, and then a patch; the patch part is recognized using the
> + fact that its first line starts with '---' (three minus signs),
> +
> +* before them there must be at least one line with only spaces.
While I agree with Michael on the other thread that we should limit
the syntax and start with ':' only, if you really want to allow
random syntax like "Bug #12345" and "Acked-by= Peff", for which you
have demonstrations in the tests in the other patch, the above rule
should be updated to also allow prefix matches to possible set of
keys defined by the user, so that an existing line that is produced
by your tool, e.g. "Acked-by= Peff", can be picked up as matching
with some token having a key "Acked-by= ". Otherwise, the input
side of your tool is inconsistent with the output side of your own
tool, and that will make the flexiblity of the output side useless.
next prev parent reply other threads:[~2014-05-28 19:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 5:32 [PATCH v12 00/11] Add interpret-trailers builtin Christian Couder
2014-05-25 5:32 ` [PATCH v12 01/11] trailer: add data structures and basic functions Christian Couder
2014-05-25 5:32 ` [PATCH v12 02/11] trailer: process trailers from input message and arguments Christian Couder
2014-05-25 5:32 ` [PATCH v12 03/11] trailer: read and process config information Christian Couder
2014-05-25 5:32 ` [PATCH v12 04/11] trailer: process command line trailer arguments Christian Couder
2014-05-25 5:32 ` [PATCH v12 05/11] trailer: parse trailers from file or stdin Christian Couder
2014-05-25 5:32 ` [PATCH v12 06/11] trailer: put all the processing together and print Christian Couder
2014-05-25 5:32 ` [PATCH v12 07/11] trailer: add interpret-trailers command Christian Couder
2014-05-25 5:32 ` [PATCH v12 08/11] trailer: add tests for "git interpret-trailers" Christian Couder
2014-05-28 19:28 ` Junio C Hamano
2014-05-25 5:32 ` [PATCH v12 09/11] trailer: execute command from 'trailer.<name>.command' Christian Couder
2014-05-25 5:32 ` [PATCH v12 10/11] trailer: add tests for commands in config file Christian Couder
2014-05-25 5:32 ` [PATCH v12 11/11] Documentation: add documentation for 'git interpret-trailers' Christian Couder
2014-05-28 19:35 ` Junio C Hamano [this message]
2014-06-29 9:37 ` Christian Couder
2014-06-30 6:40 ` Junio C Hamano
2014-05-28 19:44 ` Junio C Hamano
2014-06-30 11:57 ` Jakub Narębski
2014-07-01 13:34 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegzdd7cm.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=dan.carpenter@oracle.com \
--cc=git@vger.kernel.org \
--cc=greg@kroah.com \
--cc=johan@herland.net \
--cc=josh@joshtriplett.org \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=sunshine@sunshineco.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.