From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] remote-helpers: point at their upstream repositories
Date: Mon, 19 May 2014 12:01:08 -0700 [thread overview]
Message-ID: <xmqqegzp1tl7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53795ef8e4023_10da88d30825@nysa.notmuch> (Felipe Contreras's message of "Sun, 18 May 2014 20:31:36 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Junio C Hamano wrote:
>
>> 2. add warning that is given every time the scripts are run and
>> give the same instruction as in README.
>>
>> 3. (optional) cripple the script to make them always fail after
>> showing the same warning as above.
>
> This is what I want, and I already sent the patches for; the scripts
> will be stubs. At this point you would have effectively removed the
> code, which what I want.
>
>> 4. Keep README and retire everything else.
>
> After you've removed the code, I don't care what you do, but I'd say you
> should remove the stubs after a long period of time.
Let's try this in a different way, as I sense there is a
misunderstanding somewhere about your "wish".
>> "that" does not refer to "remove them at v2.0 (unconditional)". It
>> refers to "If Felipe really wants for the removal for v2.0, I would
>> respect that". And I saw you said you did not want to disrupt v2.0.
>>
>> If the options I listed all meant removal at v2.0, then I would
>> understand your complaints, but that is not the case, so I am not
>> sure what to make of that.
>
> It is a weird choice of semantics then. You said you would "respect" my
> wish, but your proposals did not "follow" my wish.
I understand you do not want to disrupt v2.0. My assumption of that
"not disrupting v2.0" has been "there still are git-remote-{hg,bzr}
that work just like what they had in v1.9.x, perhaps with some
enhancements and regressions you added in the meantime", and I
understood Peff's comment "If Felipe wants the removal" to mean that
kind of "disruption", i.e. "there is no git-remote-{hg,bzr} that
work.", which would be either step 3 or 4.
But your "After you've removed the code" comment above makes me
wonder that perhaps your definition of "not disrupting" was
different from ours (which is not good or bad, just different) and
you consider that step 3. is "removal but not distupting v2.0"?
If that is what you want in v2.0, then please say so, and I already
said I am fine with that.
next prev parent reply other threads:[~2014-05-19 19:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 22:56 [PATCH] remote-helpers: point at their upstream repositories Junio C Hamano
2014-05-16 7:37 ` Felipe Contreras
2014-05-16 8:41 ` Jeff King
2014-05-16 8:55 ` Paolo Ciarrocchi
2014-05-16 8:59 ` Jeff King
2014-05-16 9:03 ` Felipe Contreras
2014-05-16 9:23 ` Felipe Contreras
2014-05-16 16:52 ` Junio C Hamano
2014-05-16 22:39 ` Felipe Contreras
2014-05-17 2:11 ` James Denholm
2014-05-17 5:24 ` Felipe Contreras
2014-05-18 1:24 ` James Denholm
2014-05-18 2:31 ` Felipe Contreras
2014-05-18 23:05 ` Junio C Hamano
2014-05-19 1:19 ` Felipe Contreras
2014-05-19 21:31 ` Junio C Hamano
2014-05-20 14:55 ` Michael Haggerty
2014-05-20 15:20 ` Johan Herland
2014-05-20 21:31 ` Felipe Contreras
2014-05-20 20:52 ` Felipe Contreras
2014-05-16 22:52 ` Jeff King
2014-05-17 5:25 ` Felipe Contreras
2014-05-17 6:24 ` Jeff King
2014-05-17 17:15 ` Felipe Contreras
2014-05-18 17:34 ` Matthieu Moy
2014-05-18 22:48 ` Felipe Contreras
2014-05-18 23:13 ` Junio C Hamano
2014-05-19 1:31 ` Felipe Contreras
2014-05-19 6:11 ` Junio C Hamano
2014-05-19 21:21 ` Felipe Contreras
2014-05-19 22:27 ` Junio C Hamano
2014-05-19 23:17 ` Junio C Hamano
2014-05-20 2:06 ` Felipe Contreras
2014-05-20 4:32 ` Junio C Hamano
2014-05-19 19:01 ` Junio C Hamano [this message]
2014-05-20 20:39 ` Felipe Contreras
2014-05-20 21:11 ` Junio C Hamano
2014-05-20 21:28 ` Felipe Contreras
2014-05-20 21:50 ` Junio C Hamano
2014-05-16 18:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegzp1tl7.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.