From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 2/3] remote-helpers: move out of contrib
Date: Mon, 21 Apr 2014 14:42:45 -0700 [thread overview]
Message-ID: <xmqqeh0q8ilm.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53558c7fbd4d4_604be1f30c30@nysa.notmuch> (Felipe Contreras's message of "Mon, 21 Apr 2014 16:24:15 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
>> Does this change relate to the moving of main scripts, and if so
>> how?
>
> Yes.
>
> Before the scripts were not generated, the shebang was '/usr/bin/env python',
> that means if the user doesn't have 'python' but 'python2' git-remote-hg would
> fail, even if the user did PYTHON_PATH=python2, therefore the test scripts
> should fail too, and that's the reason 'python' is used in the test scripts.
Ahh, OK, I agree that is a sensible change, then. I would think
that deserves to be explained in the proposed log message, though.
next prev parent reply other threads:[~2014-04-21 21:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 20:37 [PATCH v2 0/3] remote-helpers: graduate Felipe Contreras
2014-04-21 20:37 ` [PATCH v2 1/3] remote-helpers: squelch python import exceptions Felipe Contreras
2014-04-21 20:37 ` [PATCH v2 2/3] remote-helpers: move out of contrib Felipe Contreras
2014-04-21 21:22 ` Junio C Hamano
2014-04-21 21:24 ` Felipe Contreras
2014-04-21 21:42 ` Junio C Hamano [this message]
2014-04-23 13:10 ` Max Horn
2014-04-23 19:20 ` Junio C Hamano
2014-04-23 21:00 ` Felipe Contreras
2014-04-23 21:30 ` Junio C Hamano
2014-04-23 20:12 ` Junio C Hamano
2014-04-23 20:54 ` Felipe Contreras
2014-04-23 22:41 ` Max Horn
2014-04-24 0:23 ` Felipe Contreras
2014-04-25 22:26 ` Max Horn
2014-04-26 1:28 ` Felipe Contreras
2014-04-21 20:37 ` [PATCH v2 3/3] remote-helpers: move tests " Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeh0q8ilm.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.