From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] split_ident: parse timestamp from end of line
Date: Tue, 15 Oct 2013 11:48:47 -0700 [thread overview]
Message-ID: <xmqqeh7me5f4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131015180312.GA26845@sigill.intra.peff.net> (Jeff King's message of "Tue, 15 Oct 2013 14:03:12 -0400")
Jeff King <peff@peff.net> writes:
> My version seems a little clearer to me, but that is probably because I
> wrote it. If you strongly prefer the other, feel free to mark up my
> patch.
I do not have strong preference either way. Just that I thought two
loops would be shorter and easier to understand than three, that's
all.
prev parent reply other threads:[~2013-10-15 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 20:27 [PATCH] split_ident: parse timestamp from end of line Jeff King
2013-10-14 22:25 ` Junio C Hamano
2013-10-14 22:31 ` Jeff King
2013-10-14 22:45 ` Jeff King
2013-10-14 22:45 ` Junio C Hamano
2013-10-14 23:29 ` Jeff King
2013-10-15 17:52 ` Junio C Hamano
2013-10-15 18:03 ` Jeff King
2013-10-15 18:48 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeh7me5f4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.