All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] die_for_incompatible_opts(): unbounded number of options
Date: Sun, 30 Aug 2026 13:55:32 -0700	[thread overview]
Message-ID: <xmqqfqzv1g6z.fsf@gitster.g> (raw)
In-Reply-To: <20260829111549.GB40814@coredump.intra.peff.net> (Jeff King's message of "Sat, 29 Aug 2026 07:15:49 -0400")

Jeff King <peff@peff.net> writes:

> On Thu, Aug 27, 2026 at 10:28:32AM -0700, Junio C Hamano wrote:
>
>> +void die_for_incompatible_opts(bool opt1, const char *opt1_name, ...)
>
> I'm mildly negative on this, just because there's no compiler support
> for making sure there is an EOF somewhere. Keeping patch 1 and using
> LAST_ARG_MUST_BE_NULL would be preferable, IMHO.

Let's discard this topic for now.

I do not like the second iteration very much, and I do not like the
1/2 preliminary step of the first iteration even less so.

Thanks.

      reply	other threads:[~2026-08-30 20:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 23:31 [PATCH 0/2] die_for_incompatible_opts(): unbounded number of options Junio C Hamano
2026-08-26 23:31 ` [PATCH 1/2] die_for_incompatible_optN: swap the order of arguments Junio C Hamano
2026-08-26 23:31 ` [PATCH 2/2] die_for_incompatible_opts(): accept more than four options Junio C Hamano
2026-08-27  1:19   ` Elijah Newren
2026-08-27 14:22     ` Junio C Hamano
2026-08-27  4:55   ` Jeff King
2026-08-27 14:35     ` Junio C Hamano
2026-08-29 11:14       ` Jeff King
2026-08-29 17:51         ` Junio C Hamano
2026-08-29 18:04         ` René Scharfe
2026-08-27 17:28 ` [PATCH v2] die_for_incompatible_opts(): unbounded number of options Junio C Hamano
2026-08-29 11:15   ` Jeff King
2026-08-30 20:55     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfqzv1g6z.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.