All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Zakariyah Ali <zakariyahali100@gmail.com>
Cc: git@vger.kernel.org,  karthik.188@gmail.com
Subject: Re: [PATCH v6] t2000: consolidate second scenario into a single test block
Date: Tue, 12 May 2026 15:15:40 +0900	[thread overview]
Message-ID: <xmqqfr3xnofn.fsf@gitster.g> (raw)
In-Reply-To: <20260429103607.406339-1-zakariyahali100@gmail.com> (Zakariyah Ali's message of "Wed, 29 Apr 2026 11:36:06 +0100")

Zakariyah Ali <zakariyahali100@gmail.com> writes:

> The second test scenario in t2000 consists of several fragmented
> test_expect_success blocks that handle data setup, tree writes,
> execution of git-checkout-index, and final state validation.
>
> Consolidate these nine separate blocks into a single self-contained
> test block. This follows the modern Git testing standard where setup,
> execution, and validation of a single logical scenario are kept
> together.
>
> As a result of this consolidation, the show_files() helper and its
> associated test_debug calls are no longer used and have been removed.
> This also removes a dependency on the non-portable 'find -ls' command.

The patch, at first glance, looked quite messy but it turns out that
it is mostly just a lot of removals of (1) early test closure
followed by the start of the next test or (2) test_debug calls in
between.  The only thing that was slightly outside that pattern was
the computation of tree3, whose result was not even used for
test_debug in the original.

Will mark the topic for 'next'.  Thanks.

  parent reply	other threads:[~2026-05-12  6:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  0:15 Github Patch Zakariyah Ali
2026-03-26  0:54 ` Pablo
2026-03-26 19:26 ` [GSoC PATCH v2] t2000: modernize path checks with test_path_is_* helpers Zakariyah Ali
2026-03-26 20:29   ` Junio C Hamano
2026-03-27 23:40   ` [GSoC][PATCH v3] t2000: modernise overall structure Zakariyah Ali
2026-03-30 12:31     ` Zakariyah Ali
2026-04-01 17:09     ` Tian Yuchen
2026-04-05  1:11     ` [PATCH v4 1/1] t2000: modernize overall structure and path checks Zakariyah Ali
2026-04-05 22:04       ` Karthik Nayak
2026-04-06 17:36         ` Tian Yuchen
2026-04-07  3:44       ` [PATCH v5] " Zakariyah Ali
2026-04-07 14:29         ` Junio C Hamano
2026-04-07 16:10           ` Junio C Hamano
2026-04-29 10:36         ` [PATCH v6] t2000: consolidate second scenario into a single test block Zakariyah Ali
2026-05-05  6:42           ` Zakariyah Ali
2026-05-12  6:15           ` Junio C Hamano [this message]
2026-05-12 20:01           ` [PATCH v6] t2000: consolidate second scenario into a single test Zakariyah Ali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfr3xnofn.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=zakariyahali100@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.