From: Junio C Hamano <gitster@pobox.com>
To: pushkarkumarsingh1970@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t1300: use test helpers instead of shell primitives
Date: Sun, 04 Jan 2026 11:39:42 +0900 [thread overview]
Message-ID: <xmqqfr8mp0cx.fsf@gitster.g> (raw)
In-Reply-To: <20260102062029.18210-1-pushkarkumarsingh1970@gmail.com> (pushkarkumarsingh's message of "Fri, 2 Jan 2026 06:20:23 +0000")
pushkarkumarsingh1970@gmail.com writes:
> From: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
>
> Replace plain "test -f" checks with "test_path_is_file" and symbolic
> link checks with "test_path_is_symlink". The test framework helpers
> provide clearer diagnostics and better consistency across the test
> suite.
The "test" is often implemented as a built-in utility in a shell,
but not necessarily so. Either way, it is not correct to call it
"shell primitive", as unlike "if", "for", it is not.
next prev parent reply other threads:[~2026-01-04 2:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 6:20 [PATCH] t1300: use test helpers instead of shell primitives pushkarkumarsingh1970
2026-01-02 9:09 ` Karthik Nayak
2026-01-02 9:39 ` Pushkar Singh
2026-01-04 2:39 ` Junio C Hamano [this message]
2026-01-04 12:41 ` [PATCH v3] t1300: use test helpers instead of test builtins Pushkar Singh
2026-01-04 15:34 ` Abraham Samuel Adekunle
2026-01-04 19:40 ` Pushkar Singh
2026-01-05 10:55 ` Karthik Nayak
2026-01-05 14:13 ` Samuel Abraham
2026-01-04 19:47 ` [PATCH v4] " Pushkar Singh
2026-01-05 10:55 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfr8mp0cx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pushkarkumarsingh1970@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.