All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Patrick Steinhardt <ps@pks.im>,
	 git@vger.kernel.org,  Ramsay Jones <ramsay@ramsayjones.plus.com>,
	 irecca.kun@gmail.com,  Eli Schwartz <eschwartz@gentoo.org>
Subject: Re: [PATCH 8/8] ci: use Meson's new `--slice` option
Date: Mon, 07 Jul 2025 21:39:30 -0700	[thread overview]
Message-ID: <xmqqfrf7z471.fsf@gitster.g> (raw)
In-Reply-To: <20250708013935.GA549322@coredump.intra.peff.net> (Jeff King's message of "Mon, 7 Jul 2025 21:39:35 -0400")

Jeff King <peff@peff.net> writes:

> That does renumber the job titles. Probably not important, but they
> wouldn't match the non-meson ones anymore (though I am not sure if we
> even slice in the same way, so maybe it does not matter at all).
>
> Anyway, the more minimal fix is:
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 673b1c44b9..7739bd2d76 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -306,7 +306,7 @@ jobs:
>          path: build
>      - name: Test
>        shell: pwsh
> -      run: meson test -C build --no-rebuild --print-errorlogs --slice ${{ matrix.nr }}/10
> +      run: meson test -C build --no-rebuild --print-errorlogs --slice "$(1+${{ matrix.nr }})/10"

It is confusing that $(...) is not a command substitution in shell
but somehow performs arithmetic X-<.

>    regular:
>      name: ${{matrix.vector.jobname}} (${{matrix.vector.pool}})
>
> with the additional bonus that I can put "PowerShell Hacker" on my
> resume now.
>
> Curiously the quotes around the whole thing are required. If you do
> just:
>
>   $(1+1)/10
>
> you will get two arguments: "2" and "/10". Definitely surprising to me
> coming from a bourne shell background.

True.

  reply	other threads:[~2025-07-08  4:39 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03  9:28 [PATCH 0/8] A handful of Meson cleanups and improvements Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 1/8] meson: stop discovering native version of Python Patrick Steinhardt
2025-07-08 19:38   ` Justin Tobler
2025-07-09  6:16     ` Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 2/8] meson: stop printing 'https' option twice in our summaries Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 3/8] meson: improve summary of auto-detected features Patrick Steinhardt
2025-07-08 19:56   ` Justin Tobler
2025-07-03  9:28 ` [PATCH 4/8] meson: clean up unnecessary variables Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 5/8] meson: fix lookup of shell on MINGW64 Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 6/8] meson: fix GIT_EXEC_PATH with overridden -Dlibexecdir= Patrick Steinhardt
2025-07-03 16:39   ` Ramsay Jones
2025-07-08  8:44     ` Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 7/8] meson: update subproject wrappers Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 8/8] ci: use Meson's new `--slice` option Patrick Steinhardt
2025-07-08  0:16   ` Junio C Hamano
2025-07-08  1:12     ` Jeff King
2025-07-08  1:39       ` Jeff King
2025-07-08  4:39         ` Junio C Hamano [this message]
2025-07-08  7:16         ` Patrick Steinhardt
2025-07-08  7:57 ` [PATCH v2 0/8] A handful of Meson cleanups and improvements Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 1/8] meson: stop discovering native version of Python Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 2/8] meson: stop printing 'https' option twice in our summaries Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 3/8] meson: improve summary of auto-detected features Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 4/8] meson: clean up unnecessary variables Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 5/8] meson: fix lookup of shell on MINGW64 Patrick Steinhardt
2025-07-08 20:44     ` Justin Tobler
2025-07-08  7:57   ` [PATCH v2 6/8] meson: fix GIT_EXEC_PATH with overridden -Dlibexecdir= Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 7/8] meson: update subproject wrappers Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 8/8] ci: use Meson's new `--slice` option Patrick Steinhardt
2025-07-09  6:23 ` [PATCH v3 0/8] A handful of Meson cleanups and improvements Patrick Steinhardt
2025-07-09  6:23   ` [PATCH v3 1/8] meson: stop discovering native version of Python Patrick Steinhardt
2025-07-09 15:09     ` Junio C Hamano
2025-07-09 21:36       ` Justin Tobler
2025-07-09 22:22       ` Eli Schwartz
2025-07-09 22:40         ` Junio C Hamano
2025-07-09  6:23   ` [PATCH v3 2/8] meson: stop printing 'https' option twice in our summaries Patrick Steinhardt
2025-07-09 15:17     ` Junio C Hamano
2025-07-09  6:23   ` [PATCH v3 3/8] meson: improve summary of auto-detected features Patrick Steinhardt
2025-07-10 15:25     ` Toon Claes
2025-07-10 16:24       ` Junio C Hamano
2025-07-09  6:23   ` [PATCH v3 4/8] meson: clean up unnecessary variables Patrick Steinhardt
2025-07-09  6:23   ` [PATCH v3 5/8] meson: fix lookup of shell on MINGW64 Patrick Steinhardt
2025-07-09  6:23   ` [PATCH v3 6/8] meson: fix GIT_EXEC_PATH with overridden -Dlibexecdir= Patrick Steinhardt
2025-07-09  6:23   ` [PATCH v3 7/8] meson: update subproject wrappers Patrick Steinhardt
2025-07-09  6:23   ` [PATCH v3 8/8] ci: use Meson's new `--slice` option Patrick Steinhardt
2025-07-09 21:37   ` [PATCH v3 0/8] A handful of Meson cleanups and improvements Justin Tobler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfrf7z471.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=eschwartz@gentoo.org \
    --cc=git@vger.kernel.org \
    --cc=irecca.kun@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.