All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: git@vger.kernel.org,  Patrick Steinhardt <ps@pks.im>,
	 Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] docs: fix check-docs with WITH_BREAKING_CHANGES
Date: Fri, 07 Mar 2025 11:55:08 -0800	[thread overview]
Message-ID: <xmqqfrjoehur.fsf@gitster.g> (raw)
In-Reply-To: <56cf842a-7c1f-4354-b191-35bcc1e139bd@gmail.com> (Phillip Wood's message of "Fri, 7 Mar 2025 15:07:25 +0000")

Phillip Wood <phillip.wood123@gmail.com> writes:

> I also noticed that while we store the correct value for
> WITH_BREAKING_CHANGES in GIT-BUILD-OPTIONS it is not defined when
> building the C sources and so we still build the pack-redundant builtin.
>
> The diff below stops us from building pack-redundant with
> -Dbreaking_changes=true but still builds the documentation. I don't intend
> spending any more time one this

Thanks.

I am afraid that Patrick's plate may already be full, but I am
hoping that there are others who are interested in getting the meson
build support into a usable shape.  Any takers?


  reply	other threads:[~2025-03-07 19:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 16:11 [PATCH] docs: fix repository-layout when building with breaking changes Phillip Wood via GitGitGadget
2025-03-03 18:18 ` Junio C Hamano
2025-03-04  6:35   ` Patrick Steinhardt
2025-03-04 10:23     ` Phillip Wood
2025-03-04 16:04       ` Junio C Hamano
2025-03-05 10:42 ` [PATCH v2] " Phillip Wood via GitGitGadget
2025-03-05 15:53   ` [PATCH] docs: fix check-docs with WITH_BREAKING_CHANGES Junio C Hamano
2025-03-07 10:32     ` Phillip Wood
2025-03-07 15:07       ` Phillip Wood
2025-03-07 19:55         ` Junio C Hamano [this message]
2025-03-07 22:42         ` Karthik Nayak
2025-03-09 10:52           ` Phillip Wood
2025-03-09 10:52         ` Phillip Wood
2025-03-10  6:42           ` Patrick Steinhardt
2025-03-11 14:40             ` Patrick Steinhardt
2025-03-12 10:39               ` phillip.wood123
2025-03-12 13:43                 ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfrjoehur.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.