From: Junio C Hamano <gitster@pobox.com>
To: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Calvin Wan <calvinwan@google.com>,
Matt Liberty <mliberty@precisioninno.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] submodule status: propagate SIGPIPE
Date: Fri, 20 Sep 2024 13:06:08 -0700 [thread overview]
Message-ID: <xmqqfrpuf5u7.fsf@gitster.g> (raw)
In-Reply-To: <pull.1799.git.1726837642511.gitgitgadget@gmail.com> (Phillip Wood via GitGitGadget's message of "Fri, 20 Sep 2024 13:07:22 +0000")
"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index a46ffd49b34..a8e497ef3c6 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -30,6 +30,7 @@
> #include "advice.h"
> #include "branch.h"
> #include "list-objects-filter-options.h"
> +#include <signal.h>
Do we really need this?
As with any other Git built-in that relies on git-compat-util.h to
handle such system-dependencies, direct inclusion of system headers
like this is highly questionable.
next prev parent reply other threads:[~2024-09-20 20:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 13:07 [PATCH] submodule status: propagate SIGPIPE Phillip Wood via GitGitGadget
2024-09-20 19:01 ` Junio C Hamano
2024-09-20 20:06 ` Junio C Hamano [this message]
2024-09-21 13:23 ` phillip.wood123
2024-09-21 13:25 ` [PATCH v2] " Phillip Wood via GitGitGadget
2024-09-23 16:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfrpuf5u7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=calvinwan@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=mliberty@precisioninno.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.