From: Junio C Hamano <gitster@pobox.com>
To: "Matthias Aßhauer via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
"Louis Strous" <Louis.Strous@intellimagic.com>,
"Pranit Bauva" <pranit.bauva@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Denton Liu" <liu.denton@gmail.com>,
"Tanushree Tumane" <tanushreetumane@gmail.com>,
"Jeff Hostetler" <jeffhost@microsoft.com>,
"Miriam Rubio" <mirucam@gmail.com>,
"Matthias Aßhauer" <mha1993@live.de>
Subject: Re: [PATCH v2 3/3] docs: update when `git bisect visualize` uses `gitk`
Date: Thu, 03 Aug 2023 21:32:15 -0700 [thread overview]
Message-ID: <xmqqfs4z2zsg.fsf@gitster.g> (raw)
In-Reply-To: <042271990895c4cfdedb20c3aed3d4141df610bd.1691122124.git.gitgitgadget@gmail.com> ("Matthias Aßhauer via GitGitGadget"'s message of "Fri, 04 Aug 2023 04:08:44 +0000")
"Matthias Aßhauer via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: =?UTF-8?q?Matthias=20A=C3=9Fhauer?= <mha1993@live.de>
>
> This check has involved more environment variables than just `DISPLAY` since
> 508e84a790 (bisect view: check for MinGW32 and MacOSX in addition to X11,
> 2008-02-14), so let's update the documentation accordingly.
>
> Signed-off-by: Matthias Aßhauer <mha1993@live.de>
> ---
> Documentation/git-bisect.txt | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt
> index fbb39fbdf5d..bec8d2abb22 100644
> --- a/Documentation/git-bisect.txt
> +++ b/Documentation/git-bisect.txt
> @@ -204,9 +204,14 @@ as an alternative to `visualize`):
> $ git bisect visualize
> ------------
>
> -If the `DISPLAY` environment variable is not set, 'git log' is used
> -instead. You can also give command-line options such as `-p` and
> -`--stat`.
> +Git detects a graphical environment through various environment variables:
> +`DISPLAY`, which is set in X Window System environments on Unix systems.
> +`SESSIONNAME`, which is set under Cygwin in interactive desktop sessions.
> +`MSYSTEM`, which is set under Msys2 and Git for Windows.
> +`SECURITYSESSIONID`, which is set on macOS in interactive desktop sessions.
Great.
> +If none of these environment variables is set, 'git log' is used instead.
> +You can also give command-line options such as `-p` and `--stat`.
Micronit. I think "is set" want to be "are set", as "none" in "none
of these" is used for "not any" [*].
>
> ------------
> $ git bisect visualize --stat
[Reference]
* https://www.merriam-webster.com/video/is-none-singular-or-plural
next prev parent reply other threads:[~2023-08-04 4:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 10:28 [PATCH 0/3] git bisect visualize: find gitk on Windows again Matthias Aßhauer via GitGitGadget
2023-08-03 10:28 ` [PATCH 1/3] compat: make path_lookup() available outside mingw.c Matthias Aßhauer via GitGitGadget
2023-08-03 10:28 ` [PATCH 2/3] run-command: teach locate_in_PATH about Windows Matthias Aßhauer via GitGitGadget
2023-08-03 16:13 ` Junio C Hamano
2023-08-03 10:28 ` [PATCH 3/3] docs: update when `git bisect visualize` uses `gitk` Matthias Aßhauer via GitGitGadget
2023-08-03 16:21 ` Junio C Hamano
2023-08-03 16:00 ` [PATCH 0/3] git bisect visualize: find gitk on Windows again Junio C Hamano
2023-08-03 18:50 ` Junio C Hamano
2023-08-03 19:03 ` Matthias Aßhauer
2023-08-03 19:56 ` Junio C Hamano
2023-08-04 4:08 ` [PATCH v2 " Matthias Aßhauer via GitGitGadget
2023-08-04 4:08 ` [PATCH v2 1/3] run-command: conditionally define locate_in_PATH() Matthias Aßhauer via GitGitGadget
2023-08-04 4:23 ` Junio C Hamano
2023-08-04 5:27 ` Matthias Aßhauer
2023-08-04 16:44 ` Junio C Hamano
2023-08-04 4:08 ` [PATCH v2 2/3] compat/mingw: implement a native locate_in_PATH() Matthias Aßhauer via GitGitGadget
2023-08-04 4:23 ` Junio C Hamano
2023-08-04 4:08 ` [PATCH v2 3/3] docs: update when `git bisect visualize` uses `gitk` Matthias Aßhauer via GitGitGadget
2023-08-04 4:32 ` Junio C Hamano [this message]
2023-08-04 5:27 ` Eric Sunshine
2023-08-04 5:54 ` Matthias Aßhauer
2023-08-04 16:45 ` Junio C Hamano
2023-08-04 16:57 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfs4z2zsg.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=Louis.Strous@intellimagic.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jeffhost@microsoft.com \
--cc=liu.denton@gmail.com \
--cc=mha1993@live.de \
--cc=mirucam@gmail.com \
--cc=pranit.bauva@gmail.com \
--cc=tanushreetumane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.