All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Aguilar <davvid@gmail.com>
Cc: Fernando Ramos <greenfoo@u92.eu>,
	Git Mailing List <git@vger.kernel.org>,
	Seth House <seth@eseth.com>,
	levraiphilippeblain@gmail.com, rogi@skylittlesystem.org
Subject: Re: [PATCH 2/3] vimdiff: add tool documentation
Date: Mon, 08 Nov 2021 11:08:49 -0800	[thread overview]
Message-ID: <xmqqfss6v51a.fsf@gitster.g> (raw)
In-Reply-To: <CAJDDKr4icrigRO-2S_HVdY7+W0EGJ8XBn5dD=O-qy1tXym4u8w@mail.gmail.com> (David Aguilar's message of "Sun, 7 Nov 2021 13:24:47 -0800")

David Aguilar <davvid@gmail.com> writes:

>     (diff_mode && ... || merge_cmd_help ...) |
>     while IFS= read -r line
>     do
>        ...
>     done
>
> How come we have to unset IFS here?

We are taking the input into a single variable "line", so what are
we splitting with IFS anyway?

In any case, thanks for spotting bash-isms to avoid.  We started
allowing "local", I think, at least in the tests, but otherwise many
bash-only things like "<(process)" redirection and "${substring:4}"
substitution are simply no-no.



  parent reply	other threads:[~2021-11-08 19:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 16:09 [PATCH 0/3] vimdiff: new layout option + docs Fernando Ramos
2021-11-04 16:09 ` [PATCH 1/3] vimdiff: new implementation with layout support Fernando Ramos
2021-11-07 22:41   ` David Aguilar
2021-11-08  0:47     ` Eric Sunshine
2021-11-04 16:09 ` [PATCH 2/3] vimdiff: add tool documentation Fernando Ramos
2021-11-07 21:24   ` David Aguilar
2021-11-08  1:02     ` Eric Sunshine
2021-11-08 19:08     ` Junio C Hamano [this message]
2021-11-04 16:09 ` [PATCH 3/3] vimdiff: remove deprecated {,g,n}vimdiff{1,2,3} variants Fernando Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfss6v51a.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=greenfoo@u92.eu \
    --cc=levraiphilippeblain@gmail.com \
    --cc=rogi@skylittlesystem.org \
    --cc=seth@eseth.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.