From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
git@vger.kernel.org, wolf@oriole.systems
Subject: Re: [PATCH] rev-parse: fix mismatch quoting of separator in the message
Date: Wed, 22 Sep 2021 13:58:25 -0700 [thread overview]
Message-ID: <xmqqfstw5nv2.fsf@gitster.g> (raw)
In-Reply-To: <YUuNOcqClVjQamYh@nand.local> (Taylor Blau's message of "Wed, 22 Sep 2021 16:08:25 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> I agree. But for what it's worth, I think we should:
>
> - accept patches, such as this one, which move things in a positive
> direction
>
> - not spend a ton of time or reviewer bandwidth on conversions
> throughout the tree
>
> In other words, I'm happy to see patches like this, or little clean-ups
> along the way in related areas, but I would be unhappy to see a massive
> patch to change all instances from one to the other.
Oh, absolutely. But let's not accept a small patch that swaps one
bad style `--' to another bad one `--`, which does not improve
anything.
prev parent reply other threads:[~2021-09-22 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 11:17 [PATCH] rev-parse: fix mismatch quoting of separator in the message Bagas Sanjaya
2021-09-22 17:40 ` Taylor Blau
2021-09-22 19:28 ` Junio C Hamano
2021-09-22 19:42 ` Taylor Blau
2021-09-22 19:59 ` Ævar Arnfjörð Bjarmason
2021-09-22 20:08 ` Taylor Blau
2021-09-22 20:58 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfstw5nv2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=wolf@oriole.systems \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.