From: Junio C Hamano <gitster@pobox.com>
To: Josh Steadmon <steadmon@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] docs: fix api-trace2 doc for "too_many_files" event
Date: Fri, 04 Jun 2021 12:16:10 +0900 [thread overview]
Message-ID: <xmqqfsxy2ubp.fsf@gitster.g> (raw)
In-Reply-To: <07a3f409730fb7d725042ee24b7556d17efe4676.1622774341.git.steadmon@google.com> (Josh Steadmon's message of "Thu, 3 Jun 2021 19:41:30 -0700")
Josh Steadmon <steadmon@google.com> writes:
> In 87db61a (trace2: write discard message to sentinel files,
> 2019-10-04), we added a new "too_many_files" event for when trace2
> logging would create too many files in an output directory.
> Unfortunately, the api-trace2 doc described a "discard" event instead.
> Fix the doc to use the correct event name.
When we look at that commit again, it is immediately obvious that
this fix is correct.
Even the test added to t/t0212 with the commit uses the right event
name (naturally---otherwise the test wouldn't have passed).
Will queue. This makes me wonder if it is useful to have some sort
of "executable" documentation, though ;-)
>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
> ---
> Documentation/technical/api-trace2.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt
> index 3f52f981a2..037a91cbca 100644
> --- a/Documentation/technical/api-trace2.txt
> +++ b/Documentation/technical/api-trace2.txt
> @@ -396,14 +396,14 @@ only present on the "start" and "atexit" events.
> }
> ------------
>
> -`"discard"`::
> +`"too_many_files"`::
> This event is written to the git-trace2-discard sentinel file if there
> are too many files in the target trace directory (see the
> trace2.maxFiles config option).
> +
> ------------
> {
> - "event":"discard",
> + "event":"too_many_files",
> ...
> }
> ------------
prev parent reply other threads:[~2021-06-04 3:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 2:41 [PATCH] docs: fix api-trace2 doc for "too_many_files" event Josh Steadmon
2021-06-04 3:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfsxy2ubp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.