All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Pete Boere <pete@duel.me>,
	git@vger.kernel.org, John Lin <johnlinp@gmail.com>
Subject: Re: Extra blank lines in "git status" output have been reduced
Date: Wed, 17 Mar 2021 14:28:08 -0700	[thread overview]
Message-ID: <xmqqft0ttqqf.fsf@gitster.g> (raw)
In-Reply-To: <YFJkJvJdO5XsrvO/@coredump.intra.peff.net> (Jeff King's message of "Wed, 17 Mar 2021 16:18:46 -0400")

Jeff King <peff@peff.net> writes:

> On Wed, Mar 17, 2021 at 12:38:42PM -0700, Junio C Hamano wrote:
> ...
>> You may want to join the list discussion and stop whatever UI change
>> you find undesirable before it materializes next time.
>
> If we discover later that some portion of users prefer an older
> behavior, it may be reasonable to build on top with a config option to
> allow selecting the old or the new.

True.  I do not think this one passes the bar, as the porcelain UI
is subject to change, and it is not worth flipping and flopping
every few years.

>   - how big is the code burden to support both behaviors? In this case,
>     I don't think it's too bad; it's restoring the old newlines with a
>     conditional

Accumulated little cuts will start hurting someday, though.

I think the change was done to make the output consistent between
two cases (with or without "use X to do Y" hints), so it won't be
sufficient to conditionally revert with a switch.  An option to add
these blank lines back would also have to add extra blank lines to
places where there was (and is) no blank line, so it is more like a
new development than a partial reversion.

cf. https://lore.kernel.org/git/?q=d%3A20190415..20190615+f%3Ajohnlinp%40gmail.com

>   - how many people would actually care enough to set the option? Even
>     without a lot of code, each option is _some_ burden to carry, both
>     in the code and in the overall complexity of the interface. I'm less
>     convinced in this particular case that a lot of people care (given a
>     single comment after many releases), but perhaps those interested in
>     the change could produce data (note I said "data", not "argue more
>     vigorously" ;) ).

;-)

      reply	other threads:[~2021-03-17 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 10:22 Extra blank lines in "git status" output have been reduced Pete Boere
2021-03-17 19:38 ` Junio C Hamano
2021-03-17 20:18   ` Jeff King
2021-03-17 21:28     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqft0ttqqf.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johnlinp@gmail.com \
    --cc=peff@peff.net \
    --cc=pete@duel.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.