From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] git-send-email: fix get_maintainer.pl regression
Date: Tue, 21 Nov 2017 09:32:22 +0900 [thread overview]
Message-ID: <xmqqfu98lbe1.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAPig+cSbRrGnyDkunMFiFXbWRMAsGyuAL-0FpP1QTtjSUSY2Hg@mail.gmail.com> (Eric Sunshine's message of "Mon, 20 Nov 2017 13:57:10 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> The more I think about this, the less I consider this a bug in
> git-send-email. As noted, people might legitimately use a complex
> command (--cc-cmd="myscript--option arg"), so changing git-send-email
> to treat cc-cmd as an atomic string seems like a bad idea.
I concur. Thanks for thinking this through.
> Assuming no changes to git-send-email, to get your test working, you
> could try to figure out how to quote the script's path you're
> specifying with --cc-cmd, however, even easier would be to drop $(pwd)
> altogether. That is, instead of:
>
> --cc-cmd="$(pwd)/expected-cc-script.sh"
>
> just use:
>
> --cc-cmd=./expected-cc-script.sh
Sounds sensible.
next prev parent reply other threads:[~2017-11-21 0:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 15:48 [PATCH] git-send-email: fix get_maintainer.pl regression Alex Bennée
2017-11-16 16:46 ` Alex Bennée
2017-11-19 2:54 ` Eric Sunshine
2017-11-20 10:44 ` Alex Bennée
2017-11-20 22:34 ` Eric Sunshine
2017-11-20 18:57 ` Eric Sunshine
2017-11-21 0:07 ` Philip Oakley
2017-11-21 0:30 ` Eric Sunshine
2017-11-21 0:32 ` Junio C Hamano [this message]
2017-11-20 22:14 ` Eric Sunshine
2017-11-21 20:46 ` Alex Bennée
2017-11-21 20:52 ` Thomas Adam
2017-11-22 1:34 ` Junio C Hamano
2017-12-11 17:13 ` Alex Bennée
2017-12-11 17:26 ` Thomas Adam
2017-12-11 19:46 ` Ævar Arnfjörð Bjarmason
2017-12-12 10:30 ` Thomas Adam
2017-12-12 11:49 ` Ævar Arnfjörð Bjarmason
2017-12-12 16:40 ` Alex Bennée
2017-12-12 18:14 ` Ævar Arnfjörð Bjarmason
2017-12-12 19:35 ` Junio C Hamano
2017-12-12 21:25 ` Ævar Arnfjörð Bjarmason
2017-12-12 22:19 ` Junio C Hamano
[not found] ` <b131cc195280498ea3a77a37eff8444e@BPMBX2013-01.univ-lyon1.fr>
2017-11-22 8:22 ` Matthieu Moy
2017-11-22 9:05 ` Alex Bennée
2017-11-22 9:49 ` Thomas Adam
2017-11-22 10:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfu98lbe1.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=alex.bennee@linaro.org \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.