From: Junio C Hamano <gitster@pobox.com>
To: Domagoj Stolfa <domagoj.stolfa@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Possible git blame bug?
Date: Mon, 13 Mar 2017 15:19:47 -0700 [thread overview]
Message-ID: <xmqqfuign7jw.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170313214400.GA98717@workstation> (Domagoj Stolfa's message of "Mon, 13 Mar 2017 22:44:00 +0100")
Domagoj Stolfa <domagoj.stolfa@gmail.com> writes:
> For example, saying:
>
> $ git blame time.h --since=2017
> ^e19f2a27ed8 (Domagoj Stolfa 2017-03-12 20:43:01 +0100 33) #ifndef _SYS_TIME_H_
>
> $ git blame time.h --since=2016
> ^21613a57af9 (bz 2016-03-13 21:26:18 +0000 33) #ifndef _SYS_TIME_H_
>
> $ git blame time.h --since=2015
> ^48507f436f0 (mav 2015-03-13 21:01:25 +0000 33) #ifndef _SYS_TIME_H_
>
> and so on, with different hashes.
The output lines "^deadbeef" does *NOT* mean that commit deadbeef
changed the revision. It just is telling you that the hisory was
dug down to that revision and it was found that since that revision
there is no change (and you told the command not to bother looking
beyond that time range, so we do not know what happened before that
time).
It is understandable, when your history has a lot of merges, the
history traversal may stop at commits on different branches.
Imagine a case where the line in question never changed throughout
the history:
o---o---B
/ \
O---o---o---A---C---o---o
Imagine A is from 2015, B is from 2016 and C is from 2017. C's
first parent, i.e. C^1, is A and C^2 is B.
If you ask the command to stop digging when you hit a commit on or
before 2017-03-13 (03-13 is because today's date is appended to your
2017), your traversal will stop at C and you get a line that begins
with ^C.
If you ask it to stop at 2016, A won't be even looked at because it
is older. The command will keep digging from C to find B. If B's
parent is also newer than the cutoff, but its parent is older, then
the line will be shown with ^ and commit object name of B's parent.
If you ask it to stop at 2015, the command will first consider A
(C's earlier parent) and pass blame to the lines common between
these two commits. In this illustration, we are pretending that the
file did not change throughout the hsitory, so blame for all lines
are passed to A and we don't even look at B. Then we keep digging
through A to find the culprit, or hit a commit older than the
specified cut-off time. The line will be shown with ^A or perhaps
its ancestor.
So it is entirely sane if you saw three boundary commits named with
three different time ranges.
next prev parent reply other threads:[~2017-03-13 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 20:11 Possible git blame bug? Domagoj Stolfa
2017-03-13 20:38 ` Junio C Hamano
[not found] ` <20170313204401.GB80633@workstation>
2017-03-13 20:46 ` Domagoj Stolfa
2017-03-13 21:29 ` Junio C Hamano
2017-03-13 21:44 ` Domagoj Stolfa
2017-03-13 22:19 ` Junio C Hamano [this message]
2017-03-13 22:46 ` Junio C Hamano
2017-03-13 23:08 ` Domagoj Stolfa
2017-03-13 23:15 ` Junio C Hamano
2017-03-13 23:19 ` Domagoj Stolfa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfuign7jw.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=domagoj.stolfa@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.