From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Josh Triplett <josh@joshtriplett.org>, git@vger.kernel.org
Subject: Re: [RFC] git-format-patch: default to --from to avoid spoofed mails?
Date: Mon, 01 Aug 2016 11:59:50 -0700 [thread overview]
Message-ID: <xmqqfuqojowp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160801174316.4boo4slop77mtry4@sigill.intra.peff.net> (Jeff King's message of "Mon, 1 Aug 2016 13:43:16 -0400")
Jeff King <peff@peff.net> writes:
> I half-agree. Config that causes unpredictable behavior can break
> somebody else's script that you are running. If you say "oh, I guess I
> shouldn't set that config" and move on with your life, then the config
> hasn't really hurt anybody. If you complain to the script author that
> their script is broken, and insist that they pass the --no-foo option,
> then the script writer does not care much whether it was a config option
> or a change of default.
Hmph, I never considered that POV but you are right.
I am not sure if that argues that we have to be even more careful
not to add non-essential configuration variable, or that we can
afford to be much less careful when changing the default, though.
A little bit of both, I guess.
next prev parent reply other threads:[~2016-08-01 19:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 21:11 [RFC] git-format-patch: default to --from to avoid spoofed mails? Josh Triplett
2016-07-28 21:37 ` Junio C Hamano
2016-07-28 21:56 ` Jeff King
2016-07-28 22:14 ` Junio C Hamano
2016-07-28 23:53 ` Josh Triplett
2016-07-29 0:17 ` Jeff King
2016-07-29 0:16 ` Jeff King
2016-07-29 2:08 ` Josh Triplett
2016-07-29 22:58 ` Jeff King
2016-07-30 4:50 ` Josh Triplett
2016-07-30 5:47 ` Jeff King
2016-07-30 5:57 ` Josh Triplett
2016-07-30 9:41 ` [PATCH 0/2] format-patch: Transition the default to --from to avoid spoofed mails Josh Triplett
2016-08-01 17:35 ` [RFC] git-format-patch: default to --from to avoid spoofed mails? Junio C Hamano
2016-08-01 17:43 ` Jeff King
2016-08-01 18:59 ` Junio C Hamano [this message]
2016-07-29 0:04 ` Josh Triplett
2016-07-29 0:05 ` Josh Triplett
2016-07-29 16:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfuqojowp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=josh@joshtriplett.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.