From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
Git Mailing List <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [RFC PATCH 0/4] pathspec labels [WAS: submodule groups]
Date: Sun, 15 May 2016 12:33:04 -0700 [thread overview]
Message-ID: <xmqqfutj5d73.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqq60uf6v5d.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Sun, 15 May 2016 11:19:58 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> Instead of putting everything in under the same attribute name
>> "label", make one attribute per label? Would this work?
>>
>> *.[ch] c-group code-group
>
> The attribute subsystem expects that there will not be unbounded
> large number of attributes, so this is not a good direction to go.
Having said that, I do not mind too much if it turns out that it is
necessary to use an unbounded set of random attributes to solve a
specific problem, if the use case is good.
But even then, in order to avoid confusion and name clashes, I'd
prefer to see more like
*.[ch] group-c group-code
that is matched by
git cmd ':(group:c code)
i.e. reserve a single prefix that is not and will not be used for
other purposes.
next prev parent reply other threads:[~2016-05-15 19:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 0:19 [RFC PATCH 0/4] pathspec labels [WAS: submodule groups] Stefan Beller
2016-05-13 0:19 ` [PATCH 1/4] Documentation: correct typo in example for querying attributes Stefan Beller
2016-05-13 0:19 ` [PATCH 2/4] pathspec: move long magic parsing out of prefix_pathspec Stefan Beller
2016-05-13 0:19 ` [PATCH 3/4] pathspec: move prefix check out of the inner loop Stefan Beller
2016-05-13 4:43 ` Junio C Hamano
2016-05-13 0:19 ` [PATCH 4/4] pathspec: record labels Stefan Beller
2016-05-13 4:32 ` Junio C Hamano
2016-05-13 5:26 ` Stefan Beller
2016-05-13 5:26 ` Junio C Hamano
2016-05-13 5:41 ` Stefan Beller
2016-05-13 6:28 ` Junio C Hamano
2016-05-15 10:06 ` [RFC PATCH 0/4] pathspec labels [WAS: submodule groups] Duy Nguyen
2016-05-15 18:19 ` Junio C Hamano
2016-05-15 19:33 ` Junio C Hamano [this message]
2016-05-16 0:03 ` Duy Nguyen
2016-05-16 17:20 ` Stefan Beller
2016-05-16 17:39 ` Junio C Hamano
2016-05-16 17:48 ` Stefan Beller
2016-05-16 21:18 ` Junio C Hamano
2016-05-16 21:36 ` Stefan Beller
2016-05-16 21:50 ` Junio C Hamano
2016-05-16 22:00 ` Stefan Beller
2016-05-16 22:02 ` Junio C Hamano
2016-05-16 22:09 ` Stefan Beller
2016-05-16 22:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfutj5d73.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.