All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: git-credential-cache--daemon quits on SIGHUP, can we change it to ignore instead?
Date: Sun, 25 Oct 2015 09:58:56 -0700	[thread overview]
Message-ID: <xmqqfv0ylwa7.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAM-tV-9sNgHncsWRPh36tEY3YFORUJBA-Q6W5R=mvX_KhSmWEQ@mail.gmail.com> (Noam Postavsky's message of "Sat, 24 Oct 2015 17:47:03 -0400")

Noam Postavsky <npostavs@users.sourceforge.net> writes:

> On Tue, Oct 20, 2015 at 10:35 PM, Noam Postavsky
> <npostavs@users.sourceforge.net> wrote:
>> On Sun, Oct 18, 2015 at 1:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> I cannot speak for the person who was primarily responsible for
>>> designing this behaviour, but I happen to agree with the current
>>> behaviour in the situation where it was designed to be used.  Upon
>>> the first use in your session, the "daemon" is auto-spawned, you can
>>> keep talking with that same instance during your session, and you do
>>> not have to do anything special to shut it down when you log out.
>>> Isn't that what happens here?
>>
>> After looking at this some more, I've discovered this is NOT what
>> actually happens here. If I "git push" from a shell and then log out
>> and log in again, another "git push" does NOT ask me for a password.
>> In other words, the daemon is NOT shut down automatically when I log
>> out. Given that, does it make sense to change the daemon to ignore
>> SIGHUP, or is there some way to change it so that it does exit on
>> logout?

I have a feeling that it would be moving in a wrong direction to
change the code to ignore HUP, as I do think "logout to shutdown"
would be the desired behaviour.  If you are not seeing that happen,
perhaps the first thing to do is to figure out why and fix the code
so that it happens?

I dunno.  I'll cc Peff so that he can take a look when he comes
back.

  reply	other threads:[~2015-10-25 16:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-10 16:45 git-credential-cache--daemon quits on SIGHUP, can we change it to ignore instead? Noam Postavsky
2015-10-18 15:15 ` Noam Postavsky
2015-10-18 17:58   ` Junio C Hamano
2015-10-19  0:51     ` Noam Postavsky
2015-10-21  2:35     ` Noam Postavsky
2015-10-24 21:47       ` Noam Postavsky
2015-10-25 16:58         ` Junio C Hamano [this message]
2015-10-26 21:50           ` Jeff King
2015-10-27  0:50             ` Noam Postavsky
2015-10-27 18:41               ` Jeff King
2015-10-27 19:04                 ` Junio C Hamano
2015-10-27 17:52             ` Junio C Hamano
2015-10-27 18:47               ` Jeff King
2015-10-28  3:46                 ` Noam Postavsky
2015-10-30  0:10                   ` Jeff King
2015-10-30  0:43                     ` Noam Postavsky
2015-10-30  0:50                       ` Jeff King
2015-10-30  1:20                         ` Noam Postavsky
2015-10-30 21:08                           ` Jeff King
2015-11-09  2:58                             ` Noam Postavsky
2015-11-09 15:53                               ` Jeff King
2015-11-10  1:05                                 ` Noam Postavsky
2015-11-10 12:25                                   ` Jeff King
2015-11-10 12:26                                     ` Jeff King
2015-11-11  0:22                                       ` Noam Postavsky
2015-12-04 18:55                                     ` Junio C Hamano
2015-12-04 19:06                                       ` Jeff King
2015-12-04 20:05                                         ` Junio C Hamano
2015-12-04 23:25                                           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfv0ylwa7.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=npostavs@users.sourceforge.net \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.