From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Sundararajan R <dyoucme@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] Added tests for git reset -
Date: Tue, 10 Mar 2015 10:36:52 -0700 [thread overview]
Message-ID: <xmqqfv9c21qj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cRgA5ZMM8d+ep8cyoZpK8FubzDBNVACgGWyWdRgF+nq7w@mail.gmail.com> (Eric Sunshine's message of "Tue, 10 Mar 2015 03:49:06 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
>> +test_expect_success 'reset - with no @{-1}' '
>> + git init new --quiet &&
>
> Why --quiet?
Also, to make sure tests serve as good examples, tests should stick
to "options first and then arguments", i.e. "git init --quiet new",
if it passes options.
next prev parent reply other threads:[~2015-03-10 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 20:46 [PATCH 1/2] Adding - shorthand for @{-1} in RESET command Sundararajan R
2015-03-09 20:46 ` [PATCH 2/2] Added tests for git reset - Sundararajan R
2015-03-10 5:48 ` Torsten Bögershausen
2015-03-10 7:49 ` Eric Sunshine
2015-03-10 17:36 ` Junio C Hamano [this message]
2015-03-10 6:54 ` [PATCH 1/2] Adding - shorthand for @{-1} in RESET command Eric Sunshine
2015-03-10 17:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfv9c21qj.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=dyoucme@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.