From: Junio C Hamano <gitster@pobox.com>
To: Anton Trunov <anton.a.trunov@gmail.com>
Cc: git@vger.kernel.org, jrnieder@gmail.com, tboegi@web.de,
sunshine@sunshineco.com, charles@hashpling.org,
Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] xmerge.c: fix xdl_merge to conform with the manual
Date: Wed, 04 Mar 2015 12:01:07 -0800 [thread overview]
Message-ID: <xmqqfv9k8rcs.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54F6D3B0.60600@gmail.com> (Anton Trunov's message of "Wed, 04 Mar 2015 12:43:12 +0300")
Anton Trunov <anton.a.trunov@gmail.com> writes:
> For the code version before applying this patch the following scenario
> will take place if "git merge -Xignore-all-space remote" gets executed.
>
> base file:
> 1st line
> 2nd line
>
> master file:
> 1st line
> 2nd line with substantial change
>
> remote file:
> 1st line
> 2nd line
>
> merge result file:
> 1st line
> 2nd line with substantial change
>
> So essentially it does what "git merge -s ours remote" does in case if
> all their changes are trivial.
> This seems like reasonable solution to me: we _are_ trying to ignore
> whitespace changes and we are explicit about it.
Now, the above makes readers wonder what happens when you merged
master into the remote. I.e. in the opposite direction.
next prev parent reply other threads:[~2015-03-04 20:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 17:37 [PATCH] xmerge.c: fix xdl_merge to conform with the manual Anton Trunov
2015-03-03 20:17 ` Torsten Bögershausen
2015-03-04 7:07 ` Eric Sunshine
2015-03-04 9:55 ` Anton Trunov
2015-03-04 10:01 ` Eric Sunshine
2015-03-04 9:59 ` Anton Trunov
2015-03-03 20:32 ` Junio C Hamano
2015-03-04 9:43 ` Anton Trunov
2015-03-04 20:01 ` Junio C Hamano [this message]
2015-03-05 9:50 ` Anton Trunov
2015-03-06 8:02 ` Anton Trunov
2015-03-08 8:06 ` Junio C Hamano
2015-03-09 10:07 ` Anton Trunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfv9k8rcs.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=anton.a.trunov@gmail.com \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.