From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: David Aguilar <davvid@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] headers: include dependent headers
Date: Mon, 08 Sep 2014 10:50:20 -0700 [thread overview]
Message-ID: <xmqqfvg2ngrn.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <540B7AA3.1090201@web.de> ("René Scharfe"'s message of "Sat, 06 Sep 2014 23:20:35 +0200")
René Scharfe <l.s.r@web.de> writes:
> Am 06.09.2014 um 21:20 schrieb David Aguilar:
>> Add dependent headers so that including a header does not
>> require including additional headers.
>>
>> This makes it so that "gcc -c $header" succeeds for each header.
>>
>> Signed-off-by: David Aguilar <davvid@gmail.com>
>> ---
>
>> diff --git a/branch.h b/branch.h
>> index 64173ab..a61fd1a 100644
>> --- a/branch.h
>> +++ b/branch.h
>> @@ -3,6 +3,9 @@
>>
>> /* Functions for acting on the information about branches. */
>>
>> +#include "cache.h"
>> +#include "strbuf.h"
>
> cache.h includes strbuf.h, so the line above isn't necessary.
True, but is "gcc -c $header" something we want to please in the
first place (not an objection, but request for opinions)?
next prev parent reply other threads:[~2014-09-08 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-06 19:20 [RFC PATCH 1/2] Makefile: add check-headers target David Aguilar
2014-09-06 19:20 ` [RFC PATCH 2/2] headers: include dependent headers David Aguilar
2014-09-06 21:20 ` René Scharfe
2014-09-08 17:50 ` Junio C Hamano [this message]
2014-09-09 19:44 ` René Scharfe
2014-09-08 18:05 ` Junio C Hamano
2014-09-06 21:20 ` [RFC PATCH 1/2] Makefile: add check-headers target René Scharfe
2014-09-06 22:57 ` David Aguilar
2014-09-06 23:58 ` Jeff King
2014-09-07 0:24 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvg2ngrn.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.