From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 3/3] tag: support configuring --sort via .gitconfig
Date: Sun, 13 Jul 2014 10:10:27 -0700 [thread overview]
Message-ID: <xmqqfvi518xo.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cR9VCtNhk-FbqDM1LTCa8VeUTYXU4XEX36Rb5CxPFfLWQ@mail.gmail.com> (Eric Sunshine's message of "Sat, 12 Jul 2014 23:29:40 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
>> Made parse_sort_string take a "var" parameter, and if given will only warn
>> about invalid parameter, instead of error.
>
> This seems unnecessarily ugly since it's hard-coding specialized
> knowledge of the callers' error-reporting requirements into what
> should be a generalized parsing function. If you instead make
> parse_sort_string() responsible only for attempting to parse the
> value, but leave error-reporting to the callers, then this ugliness
> goes away. See below.
Yup, you are absolutely right. Thanks for catching my silly.
next prev parent reply other threads:[~2014-07-13 17:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 22:55 [PATCH 1/3] tag: use skip_prefix instead of magic numbers Jacob Keller
2014-07-11 22:55 ` [PATCH 2/3] tag: fix --sort tests to use cat<<-\EOF format Jacob Keller
2014-07-11 22:55 ` [PATCH 3/3] tag: support configuring --sort via .gitconfig Jacob Keller
2014-07-13 3:29 ` Eric Sunshine
2014-07-13 17:10 ` Junio C Hamano [this message]
2014-07-13 17:33 ` Jeff King
2014-07-13 18:36 ` Jeff King
2014-07-14 17:17 ` Junio C Hamano
2014-07-15 14:52 ` Keller, Jacob E
2014-07-15 16:03 ` Junio C Hamano
2014-07-15 17:27 ` Keller, Jacob E
2014-07-15 18:17 ` Junio C Hamano
2014-07-15 18:31 ` Keller, Jacob E
2014-07-15 19:12 ` Junio C Hamano
2014-07-15 20:29 ` Keller, Jacob E
2014-07-15 21:31 ` Keller, Jacob E
2014-07-15 19:10 ` Junio C Hamano
2014-07-15 23:38 ` Jeff King
2014-07-12 1:02 ` [PATCH 1/3] tag: use skip_prefix instead of magic numbers Jeff King
-- strict thread matches above, loose matches on Subject: below --
2014-07-11 20:51 Jacob Keller
2014-07-11 20:51 ` [PATCH 3/3] tag: support configuring --sort via .gitconfig Jacob Keller
2014-07-11 20:54 ` Keller, Jacob E
2014-07-11 21:06 ` Jeff King
2014-07-11 21:08 ` Keller, Jacob E
2014-07-11 22:17 ` Junio C Hamano
2014-07-11 22:30 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvi518xo.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.