From: Junio C Hamano <gitster@pobox.com>
To: Alex Vandiver <alex@chmrr.net>
Cc: git@vger.kernel.org
Subject: Re: Race condition in git push --mirror can cause silent ref rewinding
Date: Wed, 02 Jul 2014 15:20:08 -0700 [thread overview]
Message-ID: <xmqqfvijflnr.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53B47535.3020101@chmrr.net> (Alex Vandiver's message of "Wed, 02 Jul 2014 17:10:13 -0400")
Alex Vandiver <alex@chmrr.net> writes:
> [remote "github"]
> url = git@github.com:bestpractical/rt.git
> fetch = +refs/*:refs/*
> mirror = yes
"git push github master^:master" must stay a usable way to update
the published repository to an arbitrary commit, so "if set to
mirror, do not pretend that a fetch in reverse has happened during
'git push'" will not be a solution to this issue.
Perhaps removing remote.github.fetch would be one sane way forward.
Otherwise, even if your "git push" does not pretend to immediately
fetch from there (i.e. even if the reported behaviour was a bug,
without doing anything to trigger it) somebody running "git fetch"
in this repository can destroy what other person pushes into this
repository at the same time exactly the same way, I would think.
next prev parent reply other threads:[~2014-07-02 22:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 21:10 Race condition in git push --mirror can cause silent ref rewinding Alex Vandiver
2014-07-02 22:20 ` Junio C Hamano [this message]
2014-07-02 23:10 ` Alex Vandiver
2014-07-14 4:09 ` Alex Vandiver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvijflnr.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=alex@chmrr.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.