From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC PATCH] git log: support "auto" decorations
Date: Fri, 30 May 2014 13:52:11 -0700 [thread overview]
Message-ID: <xmqqfvjr7zwk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqmwdz809b.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Fri, 30 May 2014 13:44:32 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Jeff King <peff@peff.net> writes:
>
>> Subject: [PATCH] reuse commit->buffer when parsing signatures
>> ...
>> Signed-off-by: Jeff King <peff@peff.net>
>
> Hmph, unfortunately this seems to break t7510.
And I think without re-reading the patch I know what is wrong. The
length of the object and strlen(commit->buffer) would be different,
no?
prev parent reply other threads:[~2014-05-30 20:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 22:31 [RFC PATCH] git log: support "auto" decorations Linus Torvalds
2014-05-30 1:58 ` Jeff King
2014-05-30 4:54 ` Linus Torvalds
2014-05-30 6:57 ` Jeff King
2014-05-30 16:55 ` Junio C Hamano
2014-05-30 17:03 ` Jeff King
2014-05-30 17:35 ` Junio C Hamano
2014-05-30 18:34 ` Jeff King
2014-05-30 18:39 ` Jeff King
2014-05-30 20:44 ` Junio C Hamano
2014-05-30 20:48 ` Jeff King
2014-05-30 21:13 ` Junio C Hamano
2014-05-30 20:52 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvjr7zwk.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.