From: Junio C Hamano <gitster@pobox.com>
To: "Jason St. John" <jstjohn@purdue.edu>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] Documentation: use "command-line" when used as a compound adjective, and fix other minor grammatical issues
Date: Wed, 21 May 2014 12:16:11 -0700 [thread overview]
Message-ID: <xmqqfvk3osck.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAEjxke8vhao6L4wq+yDQ816iBhO5TF2TVfzV_PNP-YMLdoCsGw@mail.gmail.com> (Jason St. John's message of "Wed, 21 May 2014 15:02:10 -0400")
"Jason St. John" <jstjohn@purdue.edu> writes:
>> int main(int argc, char **argv)
>> {
>> - char *sha1_dir = getenv(DB_ENVIRONMENT), *path;
>> + char *sha1_dir, *path;
>> int len, i;
>> -
>> +
>> if (mkdir(".git", 0755) < 0) {
>> ------------------------------------------------
>>
>
> I just noticed some trailing whitespace got stripped out here by my
> text editor, and I'm not sure if this will break formatting. Should I
> resubmit this patch without the above hunk?
It is easy enough for me to edit it out from the patch just before
applying, so no need to resend. Unless there are other necessary
changes spotted by people who review the patch, that is.
Please do not quote the entire mail without trimming it down to
relevant parts.
Thanks.
next prev parent reply other threads:[~2014-05-21 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 18:52 [PATCH] Documentation: use "command-line" when used as a compound adjective, and fix other minor grammatical issues Jason St. John
2014-05-21 19:02 ` Jason St. John
2014-05-21 19:16 ` Junio C Hamano [this message]
2014-05-21 19:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvk3osck.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jstjohn@purdue.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.