From: Junio C Hamano <gitster@pobox.com>
To: Justin Lebar <jlebar@google.com>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v5 1/4] Documentation: Fix misuses of "nor"
Date: Tue, 01 Apr 2014 12:04:25 -0700 [thread overview]
Message-ID: <xmqqfvlw27nq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAMuNMfokH8cVwYmuPX7jY+i6Vp9nPKLS+7rZKUyMvw-8yDOGmQ@mail.gmail.com> (Justin Lebar's message of "Tue, 1 Apr 2014 09:48:25 -0700")
Justin Lebar <jlebar@google.com> writes:
[administrivia: please do not top-post]
> On Mon, Mar 31, 2014 at 4:19 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Four patches queued on 'pu' as-is (but retitled). I didn't read
>> everything very carefully, though.
>>
>> Thanks.
>
> It's unclear to me: Are we done with this patch queue, or do I need to
> worry about getting these patches into another branch? If the latter,
> I'll update patch v5 per your comments.
I didn't read everything very carefully, so I cannot vouch for the
correctness of all the rewrites myself, hence I will not be merging
it to 'next' or closer-to-release branches with confidence, at least
not yet. Once I hear from somebody else who proof-read the changes
(or if I find the time to do so myself), I may be able to do so. Or
somebody else (or myself) may find problems with the change and send
further review comments to the list, in which case you would want to
incorporate them in a reroll, ande the process continues on that new
version.
I do not remember there were other comments on the latest version of
the series---I suspect not many people had chance to read them yet,
so we may have to wait for "further review comments" for a few days
at least.
Thanks.
prev parent reply other threads:[~2014-04-01 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 22:11 [PATCH v5 1/4] Documentation: Fix misuses of "nor" Justin Lebar
2014-03-31 22:11 ` [PATCH v5 2/4] contrib: " Justin Lebar
2014-03-31 22:11 ` [PATCH v5 3/4] Fix misuses of "nor" in comments Justin Lebar
2014-03-31 22:11 ` [PATCH v5 4/4] Fix misuses of "nor" outside comments and in tests Justin Lebar
2014-03-31 22:27 ` Junio C Hamano
2014-03-31 23:19 ` [PATCH v5 1/4] Documentation: Fix misuses of "nor" Junio C Hamano
2014-04-01 16:48 ` Justin Lebar
2014-04-01 19:04 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvlw27nq.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jlebar@google.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.