From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>,
Kirill Likhodedov <kirill.likhodedov@jetbrains.com>
Subject: Re: [PATCH] log: properly handle decorations with chained tags
Date: Thu, 19 Dec 2013 10:44:22 -0800 [thread overview]
Message-ID: <xmqqfvpofzp5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131219031809.GG259467@vauxhall.crustytoothpaste.net> (brian m. carlson's message of "Thu, 19 Dec 2013 03:18:09 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On Tue, Dec 17, 2013 at 04:36:06PM -0800, Junio C Hamano wrote:
>> I think all we need to do, in addition to what the existing code
>> does, is to make sure that we _parse_ the object that the tag points
>> at, to avoid this problem. Something like this, perhaps, instead?
>
> Yeah, that's the clean fix I was looking for, but couldn't quite come up
> with. I'm going to re-roll with your fix instead of mine and my tests.
> Any objections to adding your sign-off?
I was actually planning to just squash 35a34ce281 as a fixup! to
your 5e65a201 and call it a day. I think your proposed log message
in the latter clearly describes why the fix is correct.
next prev parent reply other threads:[~2013-12-19 18:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 10:08 git log --no-walk --tags produces strange result for certain user Kirill Likhodedov
2013-12-07 15:04 ` Kirill Likhodedov
[not found] ` <52AEB181.9020006@alum.mit.edu>
2013-12-16 11:52 ` Kirill Likhodedov
2013-12-17 0:40 ` brian m. carlson
2013-12-17 4:28 ` [PATCH] log: properly handle decorations with chained tags brian m. carlson
2013-12-18 0:36 ` Junio C Hamano
2013-12-19 3:18 ` brian m. carlson
2013-12-19 18:44 ` Junio C Hamano [this message]
2013-12-19 23:44 ` brian m. carlson
2014-01-16 10:31 ` git log --no-walk --tags produces strange result for certain user Michael Haggerty
2014-01-17 8:28 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvpofzp5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kirill.likhodedov@jetbrains.com \
--cc=mhagger@alum.mit.edu \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.