From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, Joshua Jensen <jjensen@workspacewhiz.com>,
Brian Gernhardt <brian@gernhardtsoftware.com>
Subject: Re: [PATCH 1/2] t3103: demonstrate dir.c:treat_one_path() core.ignorecase failure
Date: Fri, 23 Aug 2013 10:21:38 -0700 [thread overview]
Message-ID: <xmqqfvu0pbkt.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1377232155-7300-2-git-send-email-sunshine@sunshineco.com> (Eric Sunshine's message of "Fri, 23 Aug 2013 00:29:14 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> @@ -21,4 +22,18 @@ test_expect_success 'ls-tree fails with non-zero exit code on broken tree' '
> test_must_fail git ls-tree -r HEAD
> '
>
> +test_expect_failure 'ls-tree directory core.ignorecase' '
> + cat >expect <<-\EOF &&
> + d/e/f
> + EOF
> + mkdir d &&
> + >d/e &&
> + git update-index --add -- d/e &&
> + rm d/e &&
> + mkdir d/e &&
> + >d/e/f &&
> + git -c core.ignorecase=true ls-files -k >actual &&
> + test_cmp expect actual
> +'
Hmm. Wouldn't it be a clearer demonstration to add to t3010 another
invocation of "ls-files -k" that was added by 3c568751 (t3010:
update to demonstrate "ls-files -k" optimization pitfalls,
2013-08-15) but with core.ignorecase=true? Something like...
t/t3010-ls-files-killed-modified.sh | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/t/t3010-ls-files-killed-modified.sh b/t/t3010-ls-files-killed-modified.sh
index 6ea7ca8..f4783ed 100755
--- a/t/t3010-ls-files-killed-modified.sh
+++ b/t/t3010-ls-files-killed-modified.sh
@@ -90,6 +90,17 @@ pathx/ju/nk
EOF
test_expect_success \
+ 'git ls-files -k to show killed files (with icase)' \
+ 'git -c core.ignorecase=true ls-files -k >.output'
+cat >.expected <<EOF
+path0/file0
+path1/file1
+path2
+path3
+pathx/ju/nk
+EOF
+
+test_expect_success \
'validate git ls-files -k output.' \
'test_cmp .expected .output'
next prev parent reply other threads:[~2013-08-23 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 4:29 [PATCH 0/2] fix t3010 failure when core.ignorecase=true Eric Sunshine
2013-08-23 4:29 ` [PATCH 1/2] t3103: demonstrate dir.c:treat_one_path() core.ignorecase failure Eric Sunshine
2013-08-23 17:21 ` Junio C Hamano [this message]
2013-08-23 4:29 ` [PATCH 2/2] dir: test_one_path: fix inconsistent behavior due to missing '/' Eric Sunshine
2013-08-25 6:00 ` Jonathan Nieder
2013-08-25 8:05 ` Eric Sunshine
2013-08-26 5:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvu0pbkt.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=jjensen@workspacewhiz.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.