From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] t3404: make tests more self-contained
Date: Wed, 21 Aug 2013 16:27:57 -0700 [thread overview]
Message-ID: <xmqqfvu2sjya.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1377112378-45511-3-git-send-email-sunshine@sunshineco.com> (Eric Sunshine's message of "Wed, 21 Aug 2013 15:12:57 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> As its very first action, t3404 installs (via set_fake_editor) a
> specialized $EDITOR which simplifies automated 'rebase -i' testing. Many
> tests rely upon this setting, thus tests which need a different editor
> must take extra care upon completion to restore $EDITOR in order to
> avoid breaking following tests. This places extra burden upon such tests
> and requires that they undesirably have extra knowledge about
> surrounding tests. Ease this burden by having each test install the
> $EDITOR it requires, rather than relying upon a global setting.
>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
Makes sense. Thanks.
next prev parent reply other threads:[~2013-08-21 23:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 19:12 [PATCH 0/3] t3404 incremental improvements Eric Sunshine
2013-08-21 19:12 ` [PATCH 1/3] t3404: preserve test_tick state across short SHA-1 collision test Eric Sunshine
2013-08-25 5:55 ` Jonathan Nieder
2013-08-25 7:53 ` Eric Sunshine
2013-08-25 8:53 ` Jonathan Nieder
2013-08-26 5:29 ` Junio C Hamano
2013-08-21 19:12 ` [PATCH 2/3] t3404: make tests more self-contained Eric Sunshine
2013-08-21 23:27 ` Junio C Hamano [this message]
2013-08-21 19:12 ` [PATCH 3/3] t3404: simplify short SHA-1 collision test Eric Sunshine
2013-08-21 23:25 ` [PATCH 0/3] t3404 incremental improvements Junio C Hamano
2013-08-22 18:17 ` Eric Sunshine
2013-08-22 19:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvu2sjya.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.