From: Junio C Hamano <gitster@pobox.com>
To: Ben Knoble <ben.knoble@gmail.com>
Cc: Ophir Bleicher via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Ophir Bleicher <ophirble@gmail.com>
Subject: Re: [PATCH] doc: fix AsciiDoc syntax
Date: Fri, 20 Nov 2026 10:08:42 -0800 [thread overview]
Message-ID: <xmqqh5hbqst1.fsf@gitster.g> (raw)
In-Reply-To: <93127462-BCFD-4086-B19D-4B640F515140@gmail.com> (Ben Knoble's message of "Fri, 20 Nov 2026 12:54:24 -0500")
Ben Knoble <ben.knoble@gmail.com> writes:
>> Fixed it to use AsciiDoc:
>>
>> https://gitgitgadget.github.io/#...[here]
>
> Good catch.
>
> While we’re at it, « here » is generally discouraged as link text.
> It’s not particularly accessible for screen-readers, for example.
I also thought that it was a funny but understandable mistake we
made, given how prevalent Markdown is these days, but didn't think
of the need to improve the link text.
Great suggestion.
>> The differences between using `gitgitgadget/git` and `git/git` as your base can
>> -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
>> +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]
>
> So perhaps we could reword this to something like
>
> Further [differences between …] are described online.
>
> with the brackets marking the link text?
Sounds good.
Thanks.
next prev parent reply other threads:[~2026-11-20 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 17:12 [PATCH] doc: fix AsciiDoc syntax Ophir Bleicher via GitGitGadget
2026-11-20 17:54 ` Ben Knoble
2026-11-20 18:08 ` Junio C Hamano [this message]
2026-11-20 18:35 ` [PATCH v2] " Ophir Bleicher via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh5hbqst1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ophirble@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.