From: Junio C Hamano <gitster@pobox.com>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org, Kristoffer Haugsbakk <code@khaugsbakk.name>,
ZheNing Hu <adlternative@gmail.com>
Subject: Re: [PATCH] doc: interpret-trailers: fix cmd examples
Date: Mon, 28 Sep 2026 11:29:30 -0700 [thread overview]
Message-ID: <xmqqh5j9mdpx.fsf@gitster.g> (raw)
In-Reply-To: <doc_trailers_cmd_examples.ce1@m5gid.xyz> (kristofferhaugsbakk@fastmail.com's message of "Sun, 27 Sep 2026 16:12:27 +0200")
kristofferhaugsbakk@fastmail.com writes:
> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>
> Fix `trailer.<key-alias>.cmd` examples which have remained unchanged
> since they were written in c364b7ef (trailer: add new .cmd config
> option, 2021-05-03). (Modulo formatting changes.)
>
> Use this example as a guide for how to phrase it:
>
> Configure a `see` trailer with a command to show the subject of a
> commit that is related, and show how it works:
This read as if you are declaring that you use a template that
invented to consistently give intro for each example, and made it
look like the use of `see` was as a placeholder. It would have
avoided the "Huh?" reaction if it were phrased like so:
Steal how example to show the `see` trailer is phrased and use
it throughout:
Configure a `see` trailer ...
Other than that, this looks good.
> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---
>
> Notes (series):
> Topic name: kh/doc-trailers-cmd-examples
>
> Documentation/git-interpret-trailers.adoc | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/git-interpret-trailers.adoc b/Documentation/git-interpret-trailers.adoc
> index 77b4f63b05c..3e81632b252 100644
> --- a/Documentation/git-interpret-trailers.adoc
> +++ b/Documentation/git-interpret-trailers.adoc
> @@ -305,9 +305,8 @@ subject
> Fix #42
> ------------
>
> -* Configure a `help` trailer with a cmd use a script `glog-find-author`
> - which search specified author identity from git log in git repository
> - and show how it works:
> +* Configure a `help` trailer with a command that searches for an author
> + identity and show how it works:
> +
> ------------
> $ cat ~/bin/glog-find-author
> @@ -329,9 +328,8 @@ Helped-by: Junio C Hamano <gitster@pobox.com>
> Helped-by: Christian Couder <christian.couder@gmail.com>
> ------------
>
> -* Configure a `ref` trailer with a cmd use a script `glog-grep`
> - to grep last relevant commit from git log in the git repository
> - and show how it works:
> +* Configure a `ref` trailer with a command that searches for the last
> + relevant commit and show how it works:
> +
> ------------
> $ cat ~/bin/glog-grep
>
> base-commit: e9019fcafe0040228b8631c30f97ae1adb61bcdc
next prev parent reply other threads:[~2026-09-28 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 14:12 [PATCH] doc: interpret-trailers: fix cmd examples kristofferhaugsbakk
2026-09-28 18:29 ` Junio C Hamano [this message]
2026-09-29 19:10 ` Kristoffer Haugsbakk
2026-10-03 16:03 ` [PATCH v2] " kristofferhaugsbakk
2026-10-04 16:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh5j9mdpx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adlternative@gmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.