All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Shlok Kulshreshtha <diy2903@gmail.com>,  git@vger.kernel.org
Subject: Re: [PATCH v3 0/2] t1100: modernize test script
Date: Tue, 14 Jul 2026 08:34:53 -0700	[thread overview]
Message-ID: <xmqqh5m1vb36.fsf@gitster.g> (raw)
In-Reply-To: <alZADk3gB5GRxUiC@pks.im> (Patrick Steinhardt's message of "Tue, 14 Jul 2026 15:56:30 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> On Tue, Jul 14, 2026 at 05:50:31PM +0530, Shlok Kulshreshtha wrote:
>> This is v3 of the microproject cleaning up
>> t/t1100-commit-tree-options.sh ("Modernize a test script").
>> 
>> Apologies, v2 crossed with Patrick's review of v1. This v3 folds in his
>> feedback as well.
>> 
>> Changes since v2:
>>   - Patch 1/2: also drop the extraneous blank line before the "flags
>>     and then non flags" test, as Patrick suggested.
>> 
>> Changes since v1 (carried over from v2):
>>   - Patch 2/2: reword the commit message to use the present tense, as
>>     Junio suggested.
>
> Thanks, this version looks good to me.

Thanks.

  reply	other threads:[~2026-07-14 15:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 14:01 [PATCH 0/2] t1100: modernize test script Shlok Kulshreshtha
2026-07-13 14:01 ` [PATCH 1/2] t1100: modernize test style Shlok Kulshreshtha
2026-07-13 16:30   ` Junio C Hamano
2026-07-14  7:39   ` Patrick Steinhardt
2026-07-13 14:01 ` [PATCH 2/2] t1100: move creation of expected output into setup test Shlok Kulshreshtha
2026-07-13 16:10   ` Junio C Hamano
2026-07-14  7:16 ` [PATCH v2 0/2] t1100: modernize test script Shlok Kulshreshtha
2026-07-14  7:16   ` [PATCH v2 1/2] t1100: modernize test style Shlok Kulshreshtha
2026-07-14  7:16   ` [PATCH v2 2/2] t1100: move creation of expected output into setup test Shlok Kulshreshtha
2026-07-14 12:20   ` [PATCH v3 0/2] t1100: modernize test script Shlok Kulshreshtha
2026-07-14 12:20     ` [PATCH v3 1/2] t1100: modernize test style Shlok Kulshreshtha
2026-07-14 12:20     ` [PATCH v3 2/2] t1100: move creation of expected output into setup test Shlok Kulshreshtha
2026-07-14 13:56     ` [PATCH v3 0/2] t1100: modernize test script Patrick Steinhardt
2026-07-14 15:34       ` Junio C Hamano [this message]
2026-07-14 16:43     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh5m1vb36.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=diy2903@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.