All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Michael Montalbo <mmontalbo@gmail.com>,
	Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH v4] SubmittingPatches: address design critiques
Date: Mon, 22 Jun 2026 05:57:13 -0700	[thread overview]
Message-ID: <xmqqh5mu3f86.fsf@gitster.g> (raw)
In-Reply-To: <ajjwYGWZ6hQWr600@pks.im> (Patrick Steinhardt's message of "Mon, 22 Jun 2026 10:20:48 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> On Sat, Jun 20, 2026 at 04:43:00PM -0700, Junio C Hamano wrote:
>> Contributors sometimes fail to answer fundamental design or
>> viability comments from reviewers and submit subsequent rounds
>> without addressing them.  When design decisions are resolved on the
>> mailing list, the final justification should be recorded in the
>> commit messages.
>> 
>> Instruct authors to be particularly mindful of critiques regarding
>> high-level design or viability, to defend their choices on the list,
>> and to accompany new iterations with clearer explanations in the cover
>> letter, responses, and revised commit messages. Also instruct them to
>> explicitly document the resolution of these concerns in the commit
>> message body to keep the historical record complete.
>> 
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>>  * Hopefully this will be the last iteration.
>
> This version looks good to me, thanks!
>
> Patrick

Thanks.

      reply	other threads:[~2026-06-22 12:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 16:06 [PATCH] SubmittingPatches: address design critiques Junio C Hamano
2026-06-18  8:50 ` [PATCH v2] " Junio C Hamano
2026-06-18 14:43   ` Kristoffer Haugsbakk
2026-06-18 16:26     ` Junio C Hamano
2026-06-19 16:17   ` [PATCH v3] " Junio C Hamano
2026-06-20 23:43     ` [PATCH v4] " Junio C Hamano
2026-06-22  8:20       ` Patrick Steinhardt
2026-06-22 12:57         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh5mu3f86.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=mmontalbo@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.