All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Burak Kaan Karaçay" <bkkaracay@gmail.com>
Cc: git@vger.kernel.org,  christian.couder@gmail.com,  ps@pks.im
Subject: Re: [GSOC PATCH 0/2] mailmap: reduce global state
Date: Thu, 19 Feb 2026 13:22:05 -0800	[thread overview]
Message-ID: <xmqqh5rc2zuq.fsf@gitster.g> (raw)
In-Reply-To: <20260219125954.3539324-1-bkkaracay@gmail.com> ("Burak Kaan Karaçay"'s message of "Thu, 19 Feb 2026 15:59:52 +0300")

Burak Kaan Karaçay <bkkaracay@gmail.com> writes:

> This patch series aims to reduce the global variable dependency of the
> mailmap subsystem:
>
>   - Patch 1 eliminates the implicit 'the_repository' dependency in the
>     'read_mailmap' and 'read_mailmap_blob' functions by adding a
>     'struct repository' parameter.
>
>   - Patch 2 removes the 'git_mailmap_file' and 'git_mailmap_blob' global
>     variables, shifting to on-demand configuration reading via the config
>     set helpers and using local variables.

These are surprisingly simple and straight-forward, as the final
destination has nothing to do with any global, and not even part of
a long-lived structure like "repo", but just a simple string_list
mailmap.  Nicely done.

Will queue.

  parent reply	other threads:[~2026-02-19 21:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 12:59 [GSOC PATCH 0/2] mailmap: reduce global state Burak Kaan Karaçay
2026-02-19 12:59 ` [GSOC PATCH 1/2] mailmap: stop using the_repository Burak Kaan Karaçay
2026-02-19 12:59 ` [GSOC PATCH 2/2] mailmap: drop global config variables Burak Kaan Karaçay
2026-02-19 21:22 ` Junio C Hamano [this message]
2026-02-19 22:50   ` [GSOC PATCH 0/2] mailmap: reduce global state Junio C Hamano
2026-02-20  6:04 ` [GSOC PATCH v2 " Burak Kaan Karaçay
2026-02-20  6:04   ` [GSOC PATCH v2 1/2] mailmap: stop using the_repository Burak Kaan Karaçay
2026-02-20  6:04   ` [GSOC PATCH v2 2/2] mailmap: drop global config variables Burak Kaan Karaçay
2026-02-20 16:16   ` [GSOC PATCH v2 0/2] mailmap: reduce global state Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh5rc2zuq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=bkkaracay@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.