From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH 5/5] repack: begin combining cruft packs with `--combine-cruft-below-size`
Date: Tue, 18 Mar 2025 09:30:14 -0700 [thread overview]
Message-ID: <xmqqh63q47zd.fsf@gitster.g> (raw)
In-Reply-To: <7f120c35e95dcf41282c87dc2d1b2640ecdc5d84.1742252411.git.me@ttaylorr.com> (Taylor Blau's message of "Mon, 17 Mar 2025 19:00:28 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> @@ -81,6 +81,14 @@ to the new separate pack will be written.
> `--max-pack-size` (if any) by default. See the documentation for
> `--max-pack-size` for more details.
>
> +--combine-cruft-below-size=<n>::
> + When generating cruft packs without pruning, only repack
> + existing cruft packs whose size is strictly less than `<n>`.
> + Cruft packs whose size is greater than or equal to `<n>` are
> + left as-is and not repacked. Useful when you want to avoid
> + repacking large cruft pack(s) in repositories that have many
> + and/or large unreachable objects.
> +
Shared with existing entries in this file, but let's strive to make
sure we explicitly mention units. --max-cruft-size=<n> is explained
to cramp below '<n>' bytes, which is great, --max-pack-size=<n> says
it accepts k/m/g suffixes and its minimum size is 1 MiB, which is
explicit enough hint that this is counted in bytes. This new entry
should hint that this is also counted in bytes.
next prev parent reply other threads:[~2025-03-18 16:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 23:00 [PATCH 0/5] repack: introduce '--combine-cruft-below-size' Taylor Blau
2025-03-17 23:00 ` [PATCH 1/5] t/t5329-pack-objects-cruft.sh: evict 'repack'-related tests Taylor Blau
2025-03-19 14:20 ` Elijah Newren
2025-03-17 23:00 ` [PATCH 2/5] t/t7704-repack-cruft.sh: clarify wording in --max-cruft-size tests Taylor Blau
2025-03-19 14:20 ` Elijah Newren
2025-03-17 23:00 ` [PATCH 3/5] t/t7704-repack-cruft.sh: consolidate `write_blob()` Taylor Blau
2025-03-17 23:00 ` [PATCH 4/5] repack: avoid combining cruft packs with `--max-cruft-size` Taylor Blau
2025-03-17 23:00 ` [PATCH 5/5] repack: begin combining cruft packs with `--combine-cruft-below-size` Taylor Blau
2025-03-18 16:30 ` Junio C Hamano [this message]
2025-03-19 22:40 ` Taylor Blau
2025-03-19 14:21 ` Elijah Newren
2025-03-19 22:50 ` Taylor Blau
2025-03-19 22:52 ` [PATCH v2 0/5] repack: introduce '--combine-cruft-below-size' Taylor Blau
2025-03-19 22:52 ` [PATCH v2 1/5] t/t5329-pack-objects-cruft.sh: evict 'repack'-related tests Taylor Blau
2025-03-19 22:52 ` [PATCH v2 2/5] t/t7704-repack-cruft.sh: clarify wording in --max-cruft-size tests Taylor Blau
2025-03-19 22:52 ` [PATCH v2 3/5] t/t7704-repack-cruft.sh: consolidate `write_blob()` Taylor Blau
2025-03-19 22:52 ` [PATCH v2 4/5] repack: avoid combining cruft packs with `--max-cruft-size` Taylor Blau
2025-03-19 22:52 ` [PATCH v2 5/5] repack: begin combining cruft packs with `--combine-cruft-below-size` Taylor Blau
2025-03-20 4:30 ` [PATCH v2 0/5] repack: introduce '--combine-cruft-below-size' Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh63q47zd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.