All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org,  Ivan Shapovalov <intelfx@intelfx.name>
Subject: Re: [PATCH] doc: centrally document various ways spell `true` and `false`
Date: Thu, 13 Mar 2025 05:26:39 -0700	[thread overview]
Message-ID: <xmqqh63xru9s.fsf@gitster.g> (raw)
In-Reply-To: <Z9IH6G7BnM0blOmH@nand.local> (Taylor Blau's message of "Wed, 12 Mar 2025 18:17:12 -0400")

Taylor Blau <me@ttaylorr.com> writes:

>> +- 'bool': canonicalize values `true`, `yes`,`on`, and positive
>> +  numbers as "true", and values `false`, `no`, `off` and `0` as
>> +  "false".
> ...
> I agree with the rest of the patch, but is this true (no pun intended
> ;-))? I thought that we might canonicalize "yes" to "yes" if the value
> we are asking about is already something other than a literal "true" or
> "false", but I don't think we do:
>
>     $ git.compile -c foo.bar=yes config --type=bool foo.bar
>     true

Sorry, but you lost me.  Isn't the above demonstration of 'yes' you
gave getting canonicalized to 'true'?

	$ for v in yes 1 2 on
	> do
	>    git -c foo.bar=$v config --type=bool foo.bar
	> done
	true
	true
	true
	true

Or are you saying that the above documents what happens, but you
think the code is wrong to do so?


> So I do think that it is worth saying "you can spell 'true' as 'yes',
> '1', ..." in the documentation, but I don't think that it is correct
> that we'll canonicalize "yes" to "true" in the case described here.

      reply	other threads:[~2025-03-13 12:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 17:20 [PATCH] doc: centrally document various ways spell `true` and `false` Junio C Hamano
2025-02-11 17:42 ` Eric Sunshine
2025-02-11 18:11   ` Junio C Hamano
2025-03-12 22:17 ` Taylor Blau
2025-03-13 12:26   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh63xru9s.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=intelfx@intelfx.name \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.