From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: win+Meson test failures due to ps/build-meson-fixes-0130 topic?
Date: Wed, 26 Feb 2025 07:55:09 -0800 [thread overview]
Message-ID: <xmqqh64gg0pu.fsf@gitster.g> (raw)
In-Reply-To: <Z77EJRJwPDGUglLk@pks.im> (Patrick Steinhardt's message of "Wed, 26 Feb 2025 08:35:01 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> Okay, the issue was in 163a3e97ac1 (meson: simplify use of the
> common-main library, 2025-01-30). In that commit we stopped using the
> common-main dependency for a couple of binaries, including
> git-remote-https and others. What I didn't realize though is that this
> also made us not use the linker arguments anymore, but those are
> required on Windows when linking an executable.
>
> I've kicked off CI jobs on GitHub to verify that the revised version of
> this patch series works alright. Once those tests pass I'll send another
> version of this patch series.
Thanks. What is a bit more worrying is that you earlier said your
other CI didn't notice anything funny. Is the reason for the
non-breakage also known (like: the two CI jobs build things
differently)?
Thanks.
next prev parent reply other threads:[~2025-02-26 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 19:45 win+Meson test failures due to ps/build-meson-fixes-0130 topic? Junio C Hamano
2025-02-26 5:45 ` Patrick Steinhardt
2025-02-26 7:27 ` Jeff King
2025-02-26 7:35 ` Patrick Steinhardt
2025-02-26 7:46 ` Jeff King
2025-02-26 8:20 ` Jeff King
2025-02-26 9:15 ` Patrick Steinhardt
2025-02-26 22:07 ` Jeff King
2025-02-26 15:55 ` Junio C Hamano [this message]
2025-02-26 16:29 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh64gg0pu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.