From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2024, #03; Mon, 4)
Date: Tue, 05 Nov 2024 16:04:35 -0800 [thread overview]
Message-ID: <xmqqh68lrzvw.fsf@gitster.g> (raw)
In-Reply-To: <20241105212849.3759572-1-jonathantanmy@google.com> (Jonathan Tan's message of "Tue, 5 Nov 2024 13:28:49 -0800")
Jonathan Tan <jonathantanmy@google.com> writes:
>> * jt/repack-local-promisor (2024-11-03) 5 commits
>> ...
>> Needs review.
>> Breaks CI (with a known fix).
>> source: <cover.1730491845.git.jonathantanmy@google.com>
>
> The fixup (in your tree) looks good.
>
> As for review, for what it's worth, Josh Steadmon has written some
> comments [1], which I've addressed. Regarding the big-picture issue
> as to whether this solution is the best one for the problem we have,
> both Han Young [2] and I have verified (with private repos) that this
> solution does not have noticeable performance issues (which was a
> concern with other solutions) and I think that this solution does well
> to preserve the concept that we know which objects are re-fetchable from
> the remote (even if we have created them locally) and which are not.
Thanks for helping me with what happened on the list while I was
away.
prev parent reply other threads:[~2024-11-06 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 8:45 What's cooking in git.git (Nov 2024, #03; Mon, 4) Junio C Hamano
2024-11-05 21:28 ` Jonathan Tan
2024-11-06 0:04 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh68lrzvw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.