From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH v2] ReviewingGuidelines: encourage positive reviews more
Date: Fri, 26 Jul 2024 13:20:43 -0700 [thread overview]
Message-ID: <xmqqh6cbucpw.fsf@gitster.g> (raw)
In-Reply-To: <ZqOVC_F4fdQUognX@tanuki> (Patrick Steinhardt's message of "Fri, 26 Jul 2024 14:22:35 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Thu, Jul 25, 2024 at 08:49:34AM -0700, Junio C Hamano wrote:
>> I saw some contributors hesitate to give a positive review on
>> patches by their coworkers. When written well, a positive review
>> does not have to be a hollow "looks good" that rubber stamps an
>> useless approval on a topic that is not interesting to others.
>>
>> Let's add a few paragraphs to encourage positive reviews, which is a
>> bit harder to give than a review to point out things to improve.
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> This version looks good to me (well, the first version already did).
> Thanks!
Thanks; will mark for 'next'.
prev parent reply other threads:[~2024-07-26 20:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 21:14 [PATCH] ReviewingGuidelines: encourage positive reviews more Junio C Hamano
2024-07-24 21:39 ` Eric Sunshine
2024-07-25 6:51 ` Patrick Steinhardt
2024-07-25 13:31 ` Derrick Stolee
2024-07-25 14:11 ` Patrick Steinhardt
2024-07-25 15:49 ` [PATCH v2] " Junio C Hamano
2024-07-26 12:22 ` Patrick Steinhardt
2024-07-26 20:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh6cbucpw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.